]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/bridge: synopsys: dw-dp: Drop useless memory allocation
authorCristian Ciocaltea <cristian.ciocaltea@collabora.com>
Mon, 9 Mar 2026 22:44:36 +0000 (00:44 +0200)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 26 Mar 2026 19:30:46 +0000 (20:30 +0100)
The bridge gets allocated and initialized implicitly via the
devm_drm_bridge_alloc() helper in dw_dp_bind().  However, this is
preceded by an explicit allocation for the same dw_dp struct, which is
never used anywhere as the return from devm_kzalloc() gets immediately
overwritten by the aforementioned helper.

Get rid of the unnecessary and confusing memory allocation.

Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patch.msgid.link/20260310-drm-rk-fixes-v2-8-645ecfb43f49@collabora.com
drivers/gpu/drm/bridge/synopsys/dw-dp.c

index 45b37885d719dcf291383499a69d7e27c36513b2..3f4530c117c738a3b7a9753a395ce83ff7a8fcfd 100644 (file)
@@ -1970,10 +1970,6 @@ struct dw_dp *dw_dp_bind(struct device *dev, struct drm_encoder *encoder,
        void __iomem *res;
        int ret;
 
-       dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);
-       if (!dp)
-               return ERR_PTR(-ENOMEM);
-
        dp = devm_drm_bridge_alloc(dev, struct dw_dp, bridge, &dw_dp_bridge_funcs);
        if (IS_ERR(dp))
                return ERR_CAST(dp);