ASoC: pxa2xx: push gpio usage into arch code

There are no remaining static platform_device users of pxa2xx ac97,
so the rest of that code path can go away as well.

Since nothing in the driver uses the gpio number now, constrain the use
of the legacy gpio interface to the architecture specific code.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260505202426.3605262-2-arnd@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c
index ff63619790383859ba111e3efe7619aa6cbd248e..c588eeea1485e277aa8a15bbd3880c88ff5e23d1 100644 (file)
--- a/arch/arm/mach-pxa/pxa27x.c
+++ b/arch/arm/mach-pxa/pxa27x.c
@@ -58,8 +58,15 @@ static unsigned long ac97_reset_config[] = {
        GPIO95_AC97_nRESET,
 };
 
-void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio)
+void pxa27x_configure_ac97reset(struct gpio_desc *gpiod, bool to_gpio)
 {
+       int reset_gpio;
+
+       if (!gpiod)
+               return;
+
+       reset_gpio = desc_to_gpio(gpiod);
+
        /*
         * This helper function is used to work around a bug in the pxa27x's
         * ac97 controller during a warm reset.  The configuration of the

diff --git a/include/linux/platform_data/asoc-pxa.h b/include/linux/platform_data/asoc-pxa.h
index 7df78867db490859aebba2e8f34a14b267703e04..0d5eaf4b100ca303042b7c6c38c1ef9ae7b02fe5 100644 (file)
--- a/include/linux/platform_data/asoc-pxa.h
+++ b/include/linux/platform_data/asoc-pxa.h
@@ -6,6 +6,6 @@
 #include <sound/pcm.h>
 #include <sound/ac97_codec.h>
 
-extern void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio);
+extern void pxa27x_configure_ac97reset(struct gpio_desc *reset_gpio, bool to_gpio);
 
 #endif

diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c
index 79eb557d4942f19df843d057bfcc0cddb28cf4d8..87e0d6b1e160e50e31fa594b3b99b5b8c3451d7b 100644 (file)
--- a/sound/arm/pxa2xx-ac97-lib.c
+++ b/sound/arm/pxa2xx-ac97-lib.c
@@ -29,7 +29,6 @@ static DECLARE_WAIT_QUEUE_HEAD(gsr_wq);
 static volatile long gsr_bits;
 static struct clk *ac97_clk;
 static struct clk *ac97conf_clk;
-static int reset_gpio;
 struct gpio_desc *rst_gpio;
 static void __iomem *ac97_reg_base;
 
@@ -140,10 +139,10 @@ static inline void pxa_ac97_warm_pxa27x(void)
        gsr_bits = 0;
 
        /* warm reset broken on Bulverde, so manually keep AC97 reset high */
-       pxa27x_configure_ac97reset(reset_gpio, true);
+       pxa27x_configure_ac97reset(rst_gpio, true);
        udelay(10);
        writel(readl(ac97_reg_base + GCR) | (GCR_WARM_RST), ac97_reg_base + GCR);
-       pxa27x_configure_ac97reset(reset_gpio, false);
+       pxa27x_configure_ac97reset(rst_gpio, false);
        udelay(500);
 }
 
@@ -328,24 +327,14 @@ int pxa2xx_ac97_hw_probe(struct platform_device *dev)
                return PTR_ERR(ac97_reg_base);
        }
 
-       if (dev->dev.of_node) {
+       if (cpu_is_pxa27x()) {
                /* Assert reset using GPIOD_OUT_HIGH, because reset is GPIO_ACTIVE_LOW */
-               rst_gpio = devm_gpiod_get(&dev->dev, "reset", GPIOD_OUT_HIGH);
-               if (IS_ERR(rst_gpio)) {
-                       ret = PTR_ERR(rst_gpio);
-                       if (ret == -ENOENT)
-                               reset_gpio = -1;
-                       else if (ret)
-                               return ret;
-               } else {
-                       reset_gpio = desc_to_gpio(rst_gpio);
-               }
-       } else {
-               if (cpu_is_pxa27x())
-                       reset_gpio = 113;
-       }
+               rst_gpio = devm_gpiod_get_optional(&dev->dev, "reset",
+                                                  GPIOD_OUT_HIGH);
+               if (IS_ERR(rst_gpio))
+                       return dev_err_probe(&dev->dev, PTR_ERR(rst_gpio),
+                                            "reset gpio failed\n");
 
-       if (cpu_is_pxa27x()) {
                /*
                 * This gpio is needed for a work-around to a bug in the ac97
                 * controller during warm reset.  The direction and level is set
@@ -353,7 +342,7 @@ int pxa2xx_ac97_hw_probe(struct platform_device *dev)
                 * AC97_nRESET alt function to generic gpio.
                 */
                gpiod_set_consumer_name(rst_gpio, "pxa27x ac97 reset");
-               pxa27x_configure_ac97reset(reset_gpio, false);
+               pxa27x_configure_ac97reset(rst_gpio, false);
 
                ac97conf_clk = clk_get(&dev->dev, "AC97CONFCLK");
                if (IS_ERR(ac97conf_clk)) {