]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/mxsfb/lcdif: move iteration-specific variables declaration inside loop in lcdif_a...
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 7 Apr 2026 12:24:18 +0000 (14:24 +0200)
committerLuca Ceresoli <luca.ceresoli@bootlin.com>
Tue, 14 Apr 2026 11:52:31 +0000 (13:52 +0200)
The bridge and ret variables are per-iteration variables, whose values
don't have to be carried to the next iteration or be used after the loop
end. Move their declaration inside the loop scope as a cleanup and to make
code clearer.

Reviewed-by: Liu Ying <victor.liu@nxp.com>
Link: https://patch.msgid.link/20260407-drm-lcdif-dbanc-v4-4-247a16e61ef9@bootlin.com
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
drivers/gpu/drm/mxsfb/lcdif_drv.c

index 1c76709c4d94d7738e380e363fa8172f6f9d156d..c8ba8f9b1da8b192305dc06859a6a1a005d85046 100644 (file)
@@ -50,14 +50,14 @@ static int lcdif_attach_bridge(struct lcdif_drm_private *lcdif)
 {
        struct device *dev = lcdif->drm->dev;
        struct device_node *ep __free(device_node) = NULL;
-       struct drm_bridge *bridge;
-       int ret;
 
        for_each_endpoint_of_node(dev->of_node, ep) {
                struct device_node *remote __free(device_node) =
                        of_graph_get_remote_port_parent(ep);
                struct of_endpoint of_ep;
+               struct drm_bridge *bridge;
                struct drm_encoder *encoder;
+               int ret;
 
                if (!of_device_is_available(remote))
                        continue;