]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/amd/display: Undo accidental fix revert in amdgpu_dm_ism.c
authorLeo Li <sunpeng.li@amd.com>
Fri, 17 Apr 2026 17:54:30 +0000 (13:54 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 21 Apr 2026 20:49:04 +0000 (16:49 -0400)
[Why]

Pausing DPM power profiles during static screen caused a bunch of
audio/performance/clock issues that were addressed in this fix:
'commit 1412482b7143 ("Revert "drm/amd/display: pause the workload setting in dm"")'

This logic in function amdgpu_dm_crtc_vblank_control_worker() was moved
to amdgpu_dm_ism.c, but the fix was lost in the process.

[How]

Reapply the fix to amdgpu_dm_ism.c

Fixes: 754003486c3c ("drm/amd/display: Add Idle state manager(ISM)")
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c

index d2f47c69921d48d34e9b95618fdd1e9fdd663cc8..d03ea3bafd4696879d342fcba5c884f81206457f 100644 (file)
@@ -270,7 +270,6 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,
        struct amdgpu_crtc *acrtc = ism_to_amdgpu_crtc(ism);
        struct amdgpu_device *adev = drm_to_adev(acrtc->base.dev);
        struct amdgpu_display_manager *dm = &adev->dm;
-       int r;
 
        trace_amdgpu_dm_ism_commit(dm->active_vblank_irq_count,
                                   vblank_enabled,
@@ -315,16 +314,7 @@ static void dm_ism_commit_idle_optimization_state(struct amdgpu_dm_ism *ism,
         */
        if (!vblank_enabled && dm->active_vblank_irq_count == 0) {
                dc_post_update_surfaces_to_stream(dm->dc);
-
-               r = amdgpu_dpm_pause_power_profile(adev, true);
-               if (r)
-                       dev_warn(adev->dev, "failed to set default power profile mode\n");
-
                dc_allow_idle_optimizations(dm->dc, true);
-
-               r = amdgpu_dpm_pause_power_profile(adev, false);
-               if (r)
-                       dev_warn(adev->dev, "failed to restore the power profile mode\n");
        }
 }