]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panel: himax-hx8394: support Waveshare DSI panels
authorDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Mon, 13 Apr 2026 14:05:33 +0000 (17:05 +0300)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Fri, 17 Apr 2026 23:10:37 +0000 (02:10 +0300)
Enable support for Waveshare 5.0" and 5.5" DSI TOUCH-A panels.

Reviewed-by: Linus Walleij <linusw@kernel.org>
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patch.msgid.link/20260413-waveshare-dsi-touch-v3-10-3aeb53022c32@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/panel/panel-himax-hx8394.c

index 1f23c50b6661fc03412d5a95ee19dc802e20ba51..bf80354567df3ea11031745ccba3b2d6a9585cb4 100644 (file)
@@ -44,6 +44,7 @@
 #define HX8394_CMD_SETID         0xc3
 #define HX8394_CMD_SETDDB        0xc4
 #define HX8394_CMD_UNKNOWN2      0xc6
+#define HX8394_CMD_UNKNOWN6      0xc7
 #define HX8394_CMD_SETCABC       0xc9
 #define HX8394_CMD_SETCABCGAIN   0xca
 #define HX8394_CMD_SETPANEL      0xcc
@@ -618,6 +619,247 @@ static const struct hx8394_panel_desc hl055fhav028c_desc = {
        .init_sequence = hl055fhav028c_init_sequence,
 };
 
+static void waveshare_5_0_inch_a_init_sequence(struct mipi_dsi_multi_context *dsi_ctx)
+{
+       /* 5.19.8 SETEXTC: Set extension command (B9h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETEXTC,
+                                    0xff, 0x83, 0x94);
+
+       /* 5.19.2 SETPOWER: Set power (B1h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETPOWER,
+                                    0x48, 0x0a, 0x6a, 0x09, 0x33, 0x54, 0x71, 0x71, 0x2e, 0x45);
+
+       /* 5.19.9 SETMIPI: Set MIPI control (BAh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETMIPI,
+                                    0x61, 0x03, 0x68, 0x6b, 0xb2, 0xc0);
+
+       /* 5.19.3 SETDISP: Set display related register (B2h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETDISP,
+                                    0x00, 0x80, 0x64, 0x0c, 0x06, 0x2f);
+
+       /* 5.19.4 SETCYC: Set display waveform cycles (B4h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETCYC,
+                                    0x1c, 0x78, 0x1c, 0x78, 0x1c, 0x78, 0x01, 0x0c, 0x86, 0x75,
+                                    0x00, 0x3f, 0x1c, 0x78, 0x1c, 0x78, 0x1c, 0x78, 0x01, 0x0c,
+                                    0x86);
+
+       /* 5.19.19 SETGIP0: Set GIP Option0 (D3h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGIP0,
+                                    0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x08, 0x08, 0x32, 0x10,
+                                    0x05, 0x00, 0x05, 0x32, 0x13, 0xc1, 0x00, 0x01, 0x32, 0x10,
+                                    0x08, 0x00, 0x00, 0x37, 0x03, 0x07, 0x07, 0x37, 0x05, 0x05,
+                                    0x37, 0x0c, 0x40);
+
+       /* 5.19.20 Set GIP Option1 (D5h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGIP1,
+                                    0x18, 0x18, 0x18, 0x18, 0x22, 0x23, 0x20, 0x21, 0x04, 0x05,
+                                    0x06, 0x07, 0x00, 0x01, 0x02, 0x03, 0x18, 0x18, 0x18, 0x18,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+                                    0x19, 0x19, 0x19, 0x19);
+
+       /* 5.19.21 Set GIP Option2 (D6h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGIP2,
+                                    0x18, 0x18, 0x19, 0x19, 0x21, 0x20, 0x23, 0x22, 0x03, 0x02,
+                                    0x01, 0x00, 0x07, 0x06, 0x05, 0x04, 0x18, 0x18, 0x18, 0x18,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+                                    0x19, 0x19, 0x18, 0x18);
+
+       /* 5.19.25 SETGAMMA: Set gamma curve related setting (E0h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGAMMA,
+                                    0x07, 0x08, 0x09, 0x0d, 0x10, 0x14, 0x16, 0x13, 0x24, 0x36,
+                                    0x48, 0x4a, 0x58, 0x6f, 0x76, 0x80, 0x97, 0xa5, 0xa8, 0xb5,
+                                    0xc6, 0x62, 0x63, 0x68, 0x6f, 0x72, 0x78, 0x7f, 0x7f, 0x00,
+                                    0x02, 0x08, 0x0d, 0x0c, 0x0e, 0x0f, 0x10, 0x24, 0x36, 0x48,
+                                    0x4a, 0x58, 0x6f, 0x78, 0x82, 0x99, 0xa4, 0xa0, 0xb1, 0xc0,
+                                    0x5e, 0x5e, 0x64, 0x6b, 0x6c, 0x73, 0x7f, 0x7f);
+
+       /* 5.19.17 SETPANEL (CCh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETPANEL,
+                                    0x0b);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN1,
+                                    0x1f, 0x73);
+
+       /* 5.19.5 SETVCOM: Set VCOM voltage (B6h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETVCOM,
+                                    0x6b, 0x6b);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN3,
+                                    0x02);
+
+       /* 5.19.11 Set register bank (BDh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETREGBANK,
+                                    0x01);
+
+       /* 5.19.2 SETPOWER: Set power (B1h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETPOWER,
+                                    0x00);
+
+       /* 5.19.11 Set register bank (BDh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETREGBANK,
+                                    0x00);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN5,
+                                    0x40, 0x81, 0x50, 0x00, 0x1a, 0xfc, 0x01);
+};
+
+static const struct drm_display_mode waveshare_5_0_inch_a_mode = {
+       .clock = 70000,
+       .hdisplay = 720,
+       .hsync_start = 720 + 40,
+       .hsync_end = 720 + 40 + 20,
+       .htotal = 720 + 40 + 20 + 20,
+       .vdisplay = 1280,
+       .vsync_start = 1280 + 30,
+       .vsync_end = 1280 + 30 + 10,
+       .vtotal = 1280 + 30 + 10 + 4,
+       .width_mm = 62,
+       .height_mm = 110,
+};
+
+static const struct hx8394_panel_desc waveshare_5_0_inch_a_desc = {
+       .mode = &waveshare_5_0_inch_a_mode,
+       .lanes = 2,
+       .mode_flags = MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
+                     MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS,
+       .format = MIPI_DSI_FMT_RGB888,
+       .init_sequence = waveshare_5_0_inch_a_init_sequence,
+};
+
+static const struct drm_display_mode waveshare_5_5_inch_a_mode = {
+       .clock = 65000,
+       .hdisplay = 720,
+       .hsync_start = 720 + 50,
+       .hsync_end = 720 + 50 + 50,
+       .htotal = 720 + 50 + 50 + 10,
+       .vdisplay = 1280,
+       .vsync_start = 1280 + 15,
+       .vsync_end = 1280 + 15 + 12,
+       .vtotal = 1280 + 15 + 12 + 4,
+       .width_mm = 62,
+       .height_mm = 110,
+};
+
+static void waveshare_5_5_inch_a_init_sequence(struct mipi_dsi_multi_context *dsi_ctx)
+{
+       /* 5.19.8 SETEXTC: Set extension command (B9h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETEXTC,
+                                    0xff, 0x83, 0x94);
+
+       /* 5.19.9 SETMIPI: Set MIPI control (BAh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETMIPI,
+                                    0x61, 0x03, 0x68, 0x6b, 0xb2, 0xc0);
+
+       /* 5.19.2 SETPOWER: Set power (B1h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETPOWER,
+                                    0x48, 0x12, 0x72, 0x09, 0x32, 0x54, 0x71, 0x71, 0x57, 0x47);
+
+       /* 5.19.3 SETDISP: Set display related register (B2h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETDISP,
+                                    0x00, 0x80, 0x64, 0x0c, 0x0d, 0x2f);
+
+       /* 5.19.4 SETCYC: Set display waveform cycles (B4h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETCYC,
+                                    0x73, 0x74, 0x73, 0x74, 0x73, 0x74, 0x01, 0x0c, 0x86, 0x75,
+                                    0x00, 0x3f, 0x73, 0x74, 0x73, 0x74, 0x73, 0x74, 0x01, 0x0c,
+                                    0x86);
+
+       /* 5.19.5 SETVCOM: Set VCOM voltage (B6h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETVCOM,
+                                    0x86, 0x86);
+
+       /* 5.19.19 SETGIP0: Set GIP Option0 (D3h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGIP0,
+                                    0x00, 0x00, 0x07, 0x07, 0x40, 0x07, 0x0c, 0x00, 0x08, 0x10,
+                                    0x08, 0x00, 0x08, 0x54, 0x15, 0x0a, 0x05, 0x0a, 0x02, 0x15,
+                                    0x06, 0x05, 0x06, 0x47, 0x44, 0x0a, 0x0a, 0x4b, 0x10, 0x07,
+                                    0x07, 0x0c, 0x40);
+
+       /* 5.19.20 Set GIP Option1 (D5h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGIP1,
+                                    0x1c, 0x1c, 0x1d, 0x1d, 0x00, 0x01, 0x02, 0x03, 0x04, 0x05,
+                                    0x06, 0x07, 0x08, 0x09, 0x0a, 0x0b, 0x24, 0x25, 0x18, 0x18,
+                                    0x26, 0x27, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x20, 0x21,
+                                    0x18, 0x18, 0x18, 0x18);
+
+       /* 5.19.21 Set GIP Option2 (D6h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGIP2,
+                                    0x1c, 0x1c, 0x1d, 0x1d, 0x07, 0x06, 0x05, 0x04, 0x03, 0x02,
+                                    0x01, 0x00, 0x0b, 0x0a, 0x09, 0x08, 0x21, 0x20, 0x18, 0x18,
+                                    0x27, 0x26, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18,
+                                    0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x18, 0x25, 0x24,
+                                    0x18, 0x18, 0x18, 0x18);
+
+       /* 5.19.25 SETGAMMA: Set gamma curve related setting (E0h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETGAMMA,
+                                    0x00, 0x13, 0x21, 0x28, 0x2b, 0x2e, 0x32, 0x2f, 0x61, 0x6e,
+                                    0x7e, 0x7b, 0x80, 0x8f, 0x91, 0x93, 0x9d, 0x9d, 0x97, 0xa4,
+                                    0xb1, 0x57, 0x55, 0x58, 0x5d, 0x60, 0x67, 0x74, 0x7f, 0x00,
+                                    0x13, 0x21, 0x28, 0x2b, 0x2e, 0x32, 0x2f, 0x61, 0x6e, 0x7d,
+                                    0x7b, 0x7f, 0x8e, 0x90, 0x93, 0x9c, 0x9d, 0x98, 0xa4, 0xb1,
+                                    0x58, 0x55, 0x59, 0x5e, 0x61, 0x68, 0x76, 0x7f);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN1,
+                                    0x1f, 0x31);
+
+       /* 5.19.17 SETPANEL (CCh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETPANEL,
+                                    0x07);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN3,
+                                    0x02);
+
+       /* 5.19.11 Set register bank (BDh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETREGBANK,
+                                    0x02);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN4,
+                                    0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,
+                                    0xff, 0xff);
+
+       /* 5.19.11 Set register bank (BDh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETREGBANK,
+                                    0x00);
+
+       /* 5.19.11 Set register bank (BDh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETREGBANK,
+                                    0x01);
+
+       /* 5.19.2 SETPOWER: Set power (B1h) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETPOWER,
+                                    0x00);
+
+       /* 5.19.11 Set register bank (BDh) */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_SETREGBANK,
+                                    0x00);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN2,
+                                    0xed);
+
+       /* Unknown command, not listed in the HX8394-F datasheet */
+       mipi_dsi_dcs_write_seq_multi(dsi_ctx, HX8394_CMD_UNKNOWN6,
+                                    0x00, 0xc0);
+};
+
+static const struct hx8394_panel_desc waveshare_5_5_inch_a_desc = {
+       .mode = &waveshare_5_5_inch_a_mode,
+       .lanes = 2,
+       .mode_flags = MIPI_DSI_MODE_VIDEO_HSE | MIPI_DSI_MODE_VIDEO |
+                     MIPI_DSI_MODE_LPM | MIPI_DSI_CLOCK_NON_CONTINUOUS,
+       .format = MIPI_DSI_FMT_RGB888,
+       .init_sequence = waveshare_5_5_inch_a_init_sequence,
+};
+
 static int hx8394_disable(struct drm_panel *panel)
 {
        struct hx8394 *ctx = panel_to_hx8394(panel);
@@ -815,6 +1057,8 @@ static const struct of_device_id hx8394_of_match[] = {
        { .compatible = "huiling,hl055fhav028c", .data = &hl055fhav028c_desc },
        { .compatible = "powkiddy,x55-panel", .data = &powkiddy_x55_desc },
        { .compatible = "microchip,ac40t08a-mipi-panel", .data = &mchp_ac40t08a_desc },
+       { .compatible = "waveshare,5.0-dsi-touch-a", .data = &waveshare_5_0_inch_a_desc },
+       { .compatible = "waveshare,5.5-dsi-touch-a", .data = &waveshare_5_5_inch_a_desc },
        { /* sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, hx8394_of_match);