]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: qcom: camss: vfe: fix PIX subdev naming on VFE lite
authorWenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Thu, 19 Mar 2026 09:09:02 +0000 (17:09 +0800)
committerBryan O'Donoghue <bod@kernel.org>
Fri, 8 May 2026 23:22:58 +0000 (00:22 +0100)
VFE lite hardware does not provide a functional PIX path, but after
the per sub-device type resource changes the PIX subdev name is still
assigned unconditionally.

Only assign the PIX subdev name on non-lite VFE variants to avoid
exposing a misleading device name.

Fixes: ae44829a4a97 ("media: qcom: camss: Add per sub-device type resources")
Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
drivers/media/platform/qcom/camss/camss-vfe.c

index 7dc937d018f6da82611855fc35fc1b6f2ebb15b7..cc9a9685f6b5401fcd838d5744446e2b201df933 100644 (file)
@@ -2055,7 +2055,7 @@ int msm_vfe_register_entities(struct vfe_device *vfe,
                v4l2_subdev_init(sd, &vfe_v4l2_ops);
                sd->internal_ops = &vfe_v4l2_internal_ops;
                sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
-               if (i == VFE_LINE_PIX)
+               if (i == VFE_LINE_PIX && vfe->res->is_lite == false)
                        snprintf(sd->name, ARRAY_SIZE(sd->name), "%s%d_%s",
                                 MSM_VFE_NAME, vfe->id, "pix");
                else