]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/scaler: eliminate dead code
authorMichał Grzelak <michal.grzelak@intel.com>
Sat, 9 May 2026 16:40:48 +0000 (18:40 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Wed, 20 May 2026 23:55:33 +0000 (02:55 +0300)
We short-cut skl_scaler_get_config() when skl_pipe_scaler_get_hw_state()
has failed. Remove codepaths that assume scaler_id < 0.

Cc: Nemesa Garg <nemesa.garg@intel.com>
Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260509164048.627399-10-michal.grzelak@intel.com
drivers/gpu/drm/i915/display/skl_scaler.c

index 6acb54d5781b0dfba7a849c26ba36da4a221569c..7994b983d509d153763997de56d6115462bc8f72 100644 (file)
@@ -991,10 +991,7 @@ void skl_scaler_get_config(struct intel_crtc_state *crtc_state)
        scaler_state->scalers[scaler_id].in_use = true;
 
        scaler_state->scaler_id = scaler_id;
-       if (scaler_id >= 0)
-               scaler_state->scaler_users |= (1 << SKL_CRTC_INDEX);
-       else
-               scaler_state->scaler_users &= ~(1 << SKL_CRTC_INDEX);
+       scaler_state->scaler_users |= (1 << SKL_CRTC_INDEX);
 }
 
 void adl_scaler_ecc_mask(const struct intel_crtc_state *crtc_state)