]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
[3.14] gh-150368: Change Windows user group to secure identifier in test_tempfile...
authorMiss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Mon, 1 Jun 2026 12:02:47 +0000 (14:02 +0200)
committerGitHub <noreply@github.com>
Mon, 1 Jun 2026 12:02:47 +0000 (12:02 +0000)
gh-150368: Change Windows user group to secure identifier in test_tempfile (GH-150369)
(cherry picked from commit 9d64c355b5471e2d27e036d3662e97567d259c61)

Co-authored-by: Dawid Konrad Kohnke <51542233+anytokin@users.noreply.github.com>
Lib/test/test_tempfile.py

index 2c524635b572e58c970daf588257116a8c6b3001..70425ce49e9da05009242df6d270a8c8ba4b3bde 100644 (file)
@@ -332,7 +332,9 @@ class TestBadTempdir:
         with _inside_empty_temp_dir():
             probe = os.path.join(tempfile.tempdir, 'probe')
             if os.name == 'nt':
-                cmd = ['icacls', tempfile.tempdir, '/deny', 'Everyone:(W)']
+                # Use security identifier *S-1-1-0 instead
+                # of localized "Everyone" to not depend on the locale.
+                cmd = ['icacls', tempfile.tempdir, '/deny', '*S-1-1-0:(W)']
                 stdout = None if support.verbose > 1 else subprocess.DEVNULL
                 subprocess.run(cmd, check=True, stdout=stdout)
             else:
@@ -355,7 +357,9 @@ class TestBadTempdir:
                     self.make_temp()
             finally:
                 if os.name == 'nt':
-                    cmd = ['icacls', tempfile.tempdir, '/grant:r', 'Everyone:(M)']
+                    # Use security identifier *S-1-1-0 instead
+                    # of localized "Everyone" to not depend on the locale.
+                    cmd = ['icacls', tempfile.tempdir, '/grant:r', '*S-1-1-0:(M)']
                     subprocess.run(cmd, check=True, stdout=stdout)
                 else:
                     os.chmod(tempfile.tempdir, oldmode)