]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: sm750fb: constify fix_id array
authorHungyu Lin <dennylin0707@gmail.com>
Wed, 1 Apr 2026 11:50:24 +0000 (11:50 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 27 Apr 2026 11:01:51 +0000 (05:01 -0600)
Add the missing 'const' qualifier to the static fix_id array to ensure
the pointer array itself is immutable.

Originally:
    static const char *fix_id[2];
The strings are constant, but the pointer array itself is writable.

With the change:
    static const char * const fix_id[2];
Both the strings and the pointer array are immutable, allowing the
compiler to treat the object as read-only.

Verified by inspecting the generated object file with 'nm':

    00000000000002b8 0000000000000010 r fix_id.3

The 'r' flag indicates the symbol is placed in a read-only section.

This does not change runtime behavior as fix_id is never modified.

Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
Link: https://patch.msgid.link/20260401115024.89-1-dennylin0707@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/sm750fb/sm750.c

index 9f3e3d37e82a11cda1607b94c6e0eeae40d122ef..c9fd73d2620dc474539ec95584a0b9d9b6edb8b3 100644 (file)
@@ -731,7 +731,7 @@ static int lynxfb_set_fbinfo(struct fb_info *info, int index)
                lynx750_ext, NULL, vesa_modes,
        };
        int cdb[] = {ARRAY_SIZE(lynx750_ext), 0, VESA_MODEDB_SIZE};
-       static const char *fix_id[2] = {
+       static const char * const fix_id[2] = {
                "sm750_fb1", "sm750_fb2",
        };