objtool/klp: Fix --debug-checksum for duplicate symbol names

find_symbol_by_name() only returns the first match, so
--debug-checksum=<func> silently ignores any subsequent duplicately
named functions after the first.

Fix that, along with a new for_each_sym_by_name() helper.

Acked-by: Song Liu <song@kernel.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 9b11cf3193b9cc9be078d710301a90f224b86417..e3604b1201f9eaf43619ad2399cd67947deb1d3c 100644 (file)
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -3677,18 +3677,23 @@ static int checksum_debug_init(struct objtool_file *file)
 
        s = dup;
        while (*s) {
-               struct symbol *func;
+               bool found = false;
+               struct symbol *sym;
                char *comma;
 
                comma = strchr(s, ',');
                if (comma)
                        *comma = '\0';
 
-               func = find_symbol_by_name(file->elf, s);
-               if (!func || !is_func_sym(func))
+               for_each_sym_by_name(file->elf, s, sym) {
+                       if (!is_func_sym(sym))
+                               continue;
+                       sym->debug_checksum = 1;
+                       found = true;
+               }
+
+               if (!found)
                        WARN("--debug-checksum: can't find '%s'", s);
-               else
-                       func->debug_checksum = 1;
 
                if (!comma)
                        break;

diff --git a/tools/objtool/include/objtool/elf.h b/tools/objtool/include/objtool/elf.h
index b142984eb9b5a74ae53798226c0f3fccd1af0c9c..00b04029023e616aac7e7b7dfb43840b1056d7da 100644 (file)
--- a/tools/objtool/include/objtool/elf.h
+++ b/tools/objtool/include/objtool/elf.h
@@ -489,6 +489,11 @@ static inline void set_sym_next_reloc(struct reloc *reloc, struct reloc *next)
 #define for_each_sym_continue(elf, sym)                                        \
        list_for_each_entry_continue(sym, &elf->symbols, global_list)
 
+#define for_each_sym_by_name(elf, _name, sym)                          \
+       elf_hash_for_each_possible(elf, symbol_name, sym, name_hash,    \
+                                  str_hash_demangled(_name))           \
+               if (strcmp(sym->name, _name)) {} else
+
 #define for_each_sym_by_demangled_name(elf, name, sym)                 \
        elf_hash_for_each_possible(elf, symbol_name, sym, name_hash,    \
                                   str_hash(name))                      \