]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising
authorMaxime Chevallier <maxime.chevallier@bootlin.com>
Tue, 28 Apr 2026 12:58:27 +0000 (14:58 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Apr 2026 00:30:05 +0000 (17:30 -0700)
When configuring the link parameters in forced mode for the AQR-105, the
Extended Next Page bit gets advertised for Multi-Gigabit modes.

This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This
contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as
the Extended Next Page advertising. This bit used to be marked as
reserved, but a proper define for it was added in :

commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page")

Let's use it instead of the ADVERTISE_RESV definition, making the code
more self-documenting.

Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260428125827.238469-1-maxime.chevallier@bootlin.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/phy/aquantia/aquantia_main.c

index 41f3676c7f1ece69ea4d1c0037df97b0130217b0..e95d391a6dc233879ae1fb2a97758b3df9600ce5 100644 (file)
@@ -385,15 +385,15 @@ static int aqr105_setup_forced(struct phy_device *phydev)
                        vend |= MDIO_AN_VEND_PROV_1000BASET_HALF;
                break;
        case SPEED_2500:
-               adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
+               adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
                vend |= MDIO_AN_VEND_PROV_2500BASET_FULL;
                break;
        case SPEED_5000:
-               adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
+               adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
                vend |= MDIO_AN_VEND_PROV_5000BASET_FULL;
                break;
        case SPEED_10000:
-               adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV);
+               adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP);
                ctrl10 |= MDIO_AN_10GBT_CTRL_ADV10G;
                break;
        default: