Reword activity message to avoid truncation

The message sent to pg_stat_activity when waiting for transactions to
end was long enough that it could get truncated when the xid included
in the string grew large. Fix by rewording to avoid truncation, using
a similar message in the logical replication code as inspiration.

Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: ChangAo Chen <cca5507@qq.com>
Discussion: https://postgr.es/m/tencent_47CA9CE2F91FF4D81D875E162AD69AA4900A@qq.com

diff --git a/src/backend/postmaster/datachecksum_state.c b/src/backend/postmaster/datachecksum_state.c
index a49a31d1281d638754c514ac9166a2f5f5d4ce9d..a6fdcf114ec7feaa3e65fa861f2bf20c73a9cfdd 100644 (file)
--- a/src/backend/postmaster/datachecksum_state.c
+++ b/src/backend/postmaster/datachecksum_state.c
@@ -1005,7 +1005,7 @@ WaitForAllTransactionsToFinish(void)
                /* Oldest running xid is older than us, so wait */
                snprintf(activity,
                                 sizeof(activity),
-                                "Waiting for current transactions to finish (waiting for %u)",
+                                "Waiting for transactions older than %u to end",
                                 waitforxid);
                pgstat_report_activity(STATE_RUNNING, activity);