]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Input: atmel_mxt_ts - set byte_offset as signed
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 4 May 2026 10:55:03 +0000 (10:55 +0000)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 4 May 2026 16:58:20 +0000 (09:58 -0700)
The calculations done to obtain byte_offset can result into a negative
number, fix its type.

This patch fixes the following sparse error:

drivers/input/touchscreen/atmel_mxt_ts.c:1481:44: warning: unsigned value that used to be signed checked against zero?
drivers/input/touchscreen/atmel_mxt_ts.c:1479:49: signed value source

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Link: https://patch.msgid.link/20260504-fix-sparse-v1-1-1071137cd280@chromium.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/atmel_mxt_ts.c

index 87c6a10381f2de3ac0c70ea1f35e0e8cfc09568c..26ba82fb60b68ca59ef382f0b4b9f28d70ef551f 100644 (file)
@@ -1397,7 +1397,8 @@ static int mxt_prepare_cfg_mem(struct mxt_data *data, struct mxt_cfg *cfg)
 {
        struct device *dev = &data->client->dev;
        struct mxt_object *object;
-       unsigned int type, instance, size, byte_offset;
+       unsigned int type, instance, size;
+       int byte_offset;
        int offset;
        int ret;
        int i;