[master] fix dnstap query/response selectors

4427.	[bug]		The "query" and "response" parameters to the
			"dnstap" option had their functions reversed.

diff --git a/CHANGES b/CHANGES
index a43bc97699e0d9845c8c028306c8ffeaed2550f1..ed00130755835432da138d15ac6044b0746fc004 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,3 +1,6 @@
+4427.  [bug]           The "query" and "response" parameters to the
+                       "dnstap" option had their functions reversed.
+
        --- 9.11.0b3 released ---
 
 4426.  [bug]           Addressed Coverity warnings. [RT #42908]

diff --git a/bin/named/server.c b/bin/named/server.c
index e57f4c5d573845c4ffa4d8c417aa70708daddabd..67fa33f2fbc074f85bbcc9cb21a2145c061f78d1 100644 (file)
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -2976,9 +2976,9 @@ configure_dnstap(const cfg_obj_t **maps, dns_view_t *view) {
                }
 
                str = cfg_obj_asstring(obj2);
-               if (strcasecmp(str, "query")) {
+               if (strcasecmp(str, "query") == 0) {
                        dt &= ~DNS_DTTYPE_RESPONSE;
-               } else if (strcasecmp(str, "response")) {
+               } else if (strcasecmp(str, "response") == 0) {
                        dt &= ~DNS_DTTYPE_QUERY;
                }