]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
NFS: replace __get_free_page() with kmalloc() in nfs_show_devname()
authorMike Rapoport (Microsoft) <rppt@kernel.org>
Sat, 23 May 2026 17:54:17 +0000 (20:54 +0300)
committerChristian Brauner <brauner@kernel.org>
Wed, 27 May 2026 13:12:23 +0000 (15:12 +0200)
nfs_show_devname() allocates a tmemporary buffer __get_free_page().

kmalloc() is a better API for such use and it also provides better
scalability and more debugging possibilities.

Replace use of __get_free_page() with kmalloc().

Signed-off-by: Mike Rapoport (Microsoft) <rppt@kernel.org>
Link: https://patch.msgid.link/20260523-b4-fs-v1-5-275e36a83f0e@kernel.org
Signed-off-by: Christian Brauner (Amutable) <brauner@kernel.org>
fs/nfs/super.c

index 4cd420b14ce3f3436199ea6f654177741d9eb48a..8f8a03a68d3d549771452fd7ad23c658c23566ad 100644 (file)
@@ -623,7 +623,7 @@ static void show_implementation_id(struct seq_file *m, struct nfs_server *nfss)
 
 int nfs_show_devname(struct seq_file *m, struct dentry *root)
 {
-       char *page = (char *) __get_free_page(GFP_KERNEL);
+       char *page = kmalloc(PAGE_SIZE, GFP_KERNEL);
        char *devname, *dummy;
        int err = 0;
        if (!page)
@@ -633,7 +633,7 @@ int nfs_show_devname(struct seq_file *m, struct dentry *root)
                err = PTR_ERR(devname);
        else
                seq_escape(m, devname, " \t\n\\");
-       free_page((unsigned long)page);
+       kfree(page);
        return err;
 }
 EXPORT_SYMBOL_GPL(nfs_show_devname);