thermal/drivers/tegra/soctherma: Switch to devm cooling device registration

Use devm_thermal_of_cooling_device_register() to simplify resource
management and avoid manual cleanup in error paths.

As a side effect this change has the benefit of solving an existing
issue. Before, the function tegra_soctherm_remove() only called
debugfs_remove_recursive() and never called thermal_cooling_device_unregister()
for any of the cooling devices registered here.

After the driver removal, the thermal framework's cdev list would
still hold references to thermal_cooling_device objects whose devdata
pointer (ts) pointed to memory already freed by the platform device's
devm cleanup.

With this change, the cooling device is unregistered when the driver
is removed, thus fixing the issue above.

Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Link: https://patch.msgid.link/20260424160019.41710-2-daniel.lezcano@oss.qualcomm.com

diff --git a/drivers/thermal/tegra/soctherm.c b/drivers/thermal/tegra/soctherm.c
index 40c3715e84c50edab98883bcc9507a2dc80f866e..6a56638c98f1bf8f3155110999d05fa13388c056 100644 (file)
--- a/drivers/thermal/tegra/soctherm.c
+++ b/drivers/thermal/tegra/soctherm.c
@@ -1707,9 +1707,9 @@ static void soctherm_init_hw_throt_cdev(struct platform_device *pdev)
                        stc->init = true;
                } else {
 
-                       tcd = thermal_of_cooling_device_register(np_stcc,
-                                                        (char *)name, ts,
-                                                        &throt_cooling_ops);
+                       tcd = devm_thermal_of_cooling_device_register(dev, np_stcc,
+                                                                     (char *)name, ts,
+                                                                     &throt_cooling_ops);
                        if (IS_ERR_OR_NULL(tcd)) {
                                dev_err(dev,
                                        "throttle-cfg: %s: failed to register cooling device\n",