]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
staging: rtl8723bs: remove unused ROMVer from struct hal_version
authorNikolay Kulikov <nikolayof23@gmail.com>
Sat, 2 May 2026 21:55:46 +0000 (00:55 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 4 May 2026 14:53:19 +0000 (16:53 +0200)
'ROMVer' field of 'sturct hal_version' never used anywhere in the
driver, so remove it to eliminate unused code.

Remove the related call to rtw_read32(), the result of which is only
used for 'ROMVer' and is no longer needed.

Signed-off-by: Nikolay Kulikov <nikolayof23@gmail.com>
Link: https://patch.msgid.link/20260502220056.59815-8-nikolayof23@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
drivers/staging/rtl8723bs/include/HalVerDef.h

index 30cae6e0439b1a52f69a4f81cefa1d9161df1b13..4cdef45ae15eb664e67278de179966758a65679a 100644 (file)
@@ -840,9 +840,6 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter)
        /*  For regulator mode. by tynli. 2011.01.14 */
        pHalData->RegulatorMode = ((value32 & SPS_SEL) ? RT_LDO_REGULATOR : RT_SWITCHING_REGULATOR);
 
-       value32 = rtw_read32(padapter, REG_GPIO_OUTSTS);
-       ChipVersion.ROMVer = ((value32 & RF_RL_ID) >> 20);      /*  ROM code version. */
-
        /*  For multi-function consideration. Added by Roger, 2010.10.06. */
        pHalData->MultiFunc = RT_MULTI_FUNC_NONE;
        value32 = rtw_read32(padapter, REG_MULTI_FUNC_CTRL);
index 249acd83c89f3b04c37d3b7472a9e86e5b48c311..90ef37b1ddaedf1dfde2972cc6661a11ea5d6ce9 100644 (file)
@@ -43,7 +43,6 @@ enum hal_vendor_e { /* tag_HAL_Manufacturer_Version_Definition */
 
 struct hal_version { /* tag_HAL_VERSION */
        bool chip_normal;       /* true - normal chip, false - test chip */
-       u8                      ROMVer;
 };
 
 /* hal_version                 VersionID; */