]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/panel: Make drm_panel_init() static
authorAlbert Esteve <aesteve@redhat.com>
Fri, 8 May 2026 07:04:50 +0000 (09:04 +0200)
committerMaxime Ripard <mripard@kernel.org>
Mon, 11 May 2026 07:14:21 +0000 (09:14 +0200)
Now that all panel drivers use devm_drm_panel_alloc(),
there are no external callers of drm_panel_init().
Make it static to prevent new users from bypassing the
refcounted allocation path.

Remove stale references to drm_panel_init() in kdocs.

Reviewed-by: Maxime Ripard <mripard@kernel.org>
Signed-off-by: Albert Esteve <aesteve@redhat.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patch.msgid.link/20260508-drm_panel_init_rm-v2-10-0bd4ac429971@redhat.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/display/drm_dp_helper.c
drivers/gpu/drm/drm_panel.c
include/drm/drm_panel.h

index a697cc227e28964cd8322803298178e7d788e820..6d5556e3c134c833f6fb1eb5e09cfde1106563fd 100644 (file)
@@ -4626,8 +4626,6 @@ static const struct backlight_ops dp_aux_bl_ops = {
  * Backlight will then be handled transparently without requiring
  * any intervention from the driver.
  *
- * drm_panel_dp_aux_backlight() must be called after the call to drm_panel_init().
- *
  * Return: 0 on success or a negative error code on failure.
  */
 int drm_panel_dp_aux_backlight(struct drm_panel *panel, struct drm_dp_aux *aux)
index a6029b699b7305cc05a40e94a7afe845bfedb601..04f4a31ed27af6a35905962cab94c54a6ef29ac2 100644 (file)
@@ -56,8 +56,9 @@ static LIST_HEAD(panel_list);
  * Initialize the panel structure for subsequent registration with
  * drm_panel_add().
  */
-void drm_panel_init(struct drm_panel *panel, struct device *dev,
-                   const struct drm_panel_funcs *funcs, int connector_type)
+static void drm_panel_init(struct drm_panel *panel, struct device *dev,
+                          const struct drm_panel_funcs *funcs,
+                          int connector_type)
 {
        if (connector_type == DRM_MODE_CONNECTOR_Unknown)
                DRM_WARN("%s: %s: a valid connector type is required!\n", __func__, dev_name(dev));
@@ -69,7 +70,6 @@ void drm_panel_init(struct drm_panel *panel, struct device *dev,
        panel->funcs = funcs;
        panel->connector_type = connector_type;
 }
-EXPORT_SYMBOL(drm_panel_init);
 
 /**
  * drm_panel_add - add a panel to the global registry
@@ -731,7 +731,6 @@ EXPORT_SYMBOL(devm_drm_panel_add_follower);
  * A typical implementation for a panel driver supporting device tree
  * will call this function at probe time. Backlight will then be handled
  * transparently without requiring any intervention from the driver.
- * drm_panel_of_backlight() must be called after the call to drm_panel_init().
  *
  * Return: 0 on success or a negative error code on failure.
  */
index 1fb9148dd095761573273b9dc9e790d6ce5a0e6f..86b3f9c65c926f480a4742ab9797681e2b6fc7ea 100644 (file)
@@ -320,10 +320,6 @@ void *__devm_drm_panel_alloc(struct device *dev, size_t size, size_t offset,
                                        offsetof(type, member), funcs, \
                                        connector_type))
 
-void drm_panel_init(struct drm_panel *panel, struct device *dev,
-                   const struct drm_panel_funcs *funcs,
-                   int connector_type);
-
 struct drm_panel *drm_panel_get(struct drm_panel *panel);
 void drm_panel_put(struct drm_panel *panel);