]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
media: s2255: refactor endpoint lookup
authorJohan Hovold <johan@kernel.org>
Mon, 30 Mar 2026 10:11:41 +0000 (12:11 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Tue, 5 May 2026 14:57:02 +0000 (16:57 +0200)
Use the common USB helper for looking up bulk-in endpoints instead of
open coding.

Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/usb/s2255/s2255drv.c

index 2c02873d09b5f763f18ee7c76b930cfc18e2d29f..0b8182edf8e4bbab938a914616d35a72670e29af 100644 (file)
@@ -2240,18 +2240,14 @@ static int s2255_probe(struct usb_interface *interface,
        iface_desc = interface->cur_altsetting;
        dev_dbg(&interface->dev, "num EP: %d\n",
                iface_desc->desc.bNumEndpoints);
-       for (i = 0; i < iface_desc->desc.bNumEndpoints; ++i) {
-               endpoint = &iface_desc->endpoint[i].desc;
-               if (!dev->read_endpoint && usb_endpoint_is_bulk_in(endpoint)) {
-                       /* we found the bulk in endpoint */
-                       dev->read_endpoint = endpoint->bEndpointAddress;
-               }
-       }
 
-       if (!dev->read_endpoint) {
+       if (usb_find_bulk_in_endpoint(iface_desc, &endpoint)) {
                dev_err(&interface->dev, "Could not find bulk-in endpoint\n");
                goto errorEP;
        }
+
+       dev->read_endpoint = endpoint->bEndpointAddress;
+
        timer_setup(&dev->timer, s2255_timer, 0);
        init_waitqueue_head(&dev->fw_data->wait_fw);
        for (i = 0; i < MAX_CHANNELS; i++) {