- bcachefs does support read-only snapshots now

diff --git a/doc/bcachefs.txt b/doc/bcachefs.txt
index b1538f296aea2ac0cdd79853809efc30b8776021..dae72ff90d37a637557d571ab4a5dc50813dfa10 100644 (file)
--- a/doc/bcachefs.txt
+++ b/doc/bcachefs.txt
@@ -5,9 +5,6 @@ TODOs (at least):
 
 - ioctl for snapshot creation takes path instead of fd
 
-- read-only snapshots not supported by bcachefs
-  - background comparison started anyway
-
 - check if a directory is a snapshot
 
 - get ioctl defines from a header file or use a library

diff --git a/snapper/BcachefsUtils.cc b/snapper/BcachefsUtils.cc
index 1d328a78352113352ddd1280ef2382fa26e9f192..a6d5a013181f176a5d5a67f0f1537a2462b04fa8 100644 (file)
--- a/snapper/BcachefsUtils.cc
+++ b/snapper/BcachefsUtils.cc
@@ -100,7 +100,7 @@ namespace snapper
 
            args.flags = BCH_SUBVOL_SNAPSHOT_CREATE;
            if (read_only)
-               args.flags |= BCH_SUBVOL_SNAPSHOT_RO;   // TODO does not work
+               args.flags |= BCH_SUBVOL_SNAPSHOT_RO;
            args.dirfd = (__u32) fddst;
            args.mode = 0777;
            args.dst_ptr = (__u64) name.c_str();