]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Remove unneeded lock master
authorAndrew Dinh <andrewd@openssl.org>
Tue, 28 Jul 2026 07:11:58 +0000 (14:11 +0700)
committerNorbert Pocs <norbertp@openssl.org>
Thu, 30 Jul 2026 06:12:29 +0000 (08:12 +0200)
The current lockless design does not need this lock around objs anymore

Assisted-by: Claude:claude-sonnet-5
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
Reviewed-by: Bob Beck <beck@openssl.org>
MergeDate: Thu Jul 30 06:12:46 2026
(Merged from https://github.com/openssl/openssl/pull/32003)

test/radix/quic_bindings.c

index fb87c2245d1ce45eaf90eb5f22cec7de2d5a4ba5..de066deb46037ec87408bc211c879d44c02dcf91 100644 (file)
@@ -66,7 +66,7 @@ typedef struct radix_process_st {
 
     /* Process-global state. */
     CRYPTO_MUTEX *gm; /* global mutex */
-    LHASH_OF(RADIX_OBJ) *objs; /* protected by gm */
+    LHASH_OF(RADIX_OBJ) *objs;
     BIO *keylog_out; /* protected by gm */
     uint64_t counter[2]; /* protected by gm */
 
@@ -892,8 +892,6 @@ DEF_FUNC(hf_clear)
     RADIX_THREAD *rt = RT();
     size_t i;
 
-    ossl_crypto_mutex_lock(RP()->gm);
-
     lh_RADIX_OBJ_doall(RP()->objs, cleanup_one);
     lh_RADIX_OBJ_flush(RP()->objs);
 
@@ -902,7 +900,6 @@ DEF_FUNC(hf_clear)
         rt->ssl[i] = NULL;
     }
 
-    ossl_crypto_mutex_unlock(RP()->gm);
     return 1;
 }