From: Nikhil Gautam Date: Tue, 14 Apr 2026 17:03:07 +0000 (+0530) Subject: iio: dac: mcp4821: move state initialization outside switch X-Git-Tag: v7.2-rc1~67^2~5^2~219 X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=090839ecff2b30fa87b73f5001cdb150673a4d4c;p=thirdparty%2Flinux.git iio: dac: mcp4821: move state initialization outside switch Move the iio_priv() call outside the switch statement in mcp4821_read_raw() to avoid repeating it in multiple cases. No functional change. Signed-off-by: Nikhil Gautam Reviewed-by: David Lechner Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/dac/mcp4821.c b/drivers/iio/dac/mcp4821.c index 29187f2a9d3c4..102ae37185148 100644 --- a/drivers/iio/dac/mcp4821.c +++ b/drivers/iio/dac/mcp4821.c @@ -115,11 +115,10 @@ static int mcp4821_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const *chan, int *val, int *val2, long mask) { - struct mcp4821_state *state; + struct mcp4821_state *state = iio_priv(indio_dev); switch (mask) { case IIO_CHAN_INFO_RAW: - state = iio_priv(indio_dev); *val = state->dac_value[chan->channel]; return IIO_VAL_INT; case IIO_CHAN_INFO_SCALE: