From: Michal Nowak <mnowak@isc.org>
Date: Mon, 25 May 2026 06:52:31 +0000 (+0000)
Subject: Fix wrong variable in named_server_sync() log message
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=1b984b1f116134d8a93c5327217487928f6d324f;p=thirdparty%2Fbind9.git

Fix wrong variable in named_server_sync() log message

named_server_sync() logged isc_result_totext(result) but returns
tresult. The loop accumulates errors into tresult, so result only
holds the last iteration's value. If the last view succeeded but an
earlier one failed, the log would incorrectly say "success".

Assisted-by: Claude:claude-opus-4-7
---

diff --git a/bin/named/server.c b/bin/named/server.c
index c58a01467e7..906e108b9a4 100644
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -11807,7 +11807,7 @@ named_server_sync(named_server_t *server, isc_lex_t *lex, isc_buffer_t *text) {
 		isc_log_write(NAMED_LOGCATEGORY_GENERAL, NAMED_LOGMODULE_SERVER,
 			      ISC_LOG_INFO, "dumping all zones%s: %s",
 			      cleanup ? ", removing journal files" : "",
-			      isc_result_totext(result));
+			      isc_result_totext(tresult));
 		return tresult;
 	}