From: Krzysztof Kozlowski Date: Fri, 9 Jan 2026 16:57:56 +0000 (+0100) Subject: media: samsung: exynos4-is: Simplify with scoped for each OF child loop X-Git-Tag: v7.1-rc1~169^2~178 X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=251475d98e36d8067d955cacc1aa08fbf89d13d2;p=thirdparty%2Fkernel%2Flinux.git media: samsung: exynos4-is: Simplify with scoped for each OF child loop Use scoped for_each_compatible_node_scoped() loop when iterating over device nodes to make code a bit simpler. Reviewed-by: Jonathan Cameron Signed-off-by: Krzysztof Kozlowski Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is.c b/drivers/media/platform/samsung/exynos4-is/fimc-is.c index 14d84cc96831c..b7d9bfedd590f 100644 --- a/drivers/media/platform/samsung/exynos4-is/fimc-is.c +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is.c @@ -200,21 +200,19 @@ static int fimc_is_parse_sensor_config(struct fimc_is *is, unsigned int index, static int fimc_is_register_subdevs(struct fimc_is *is) { - struct device_node *i2c_bus; int ret, index = 0; ret = fimc_isp_subdev_create(&is->isp); if (ret < 0) return ret; - for_each_compatible_node(i2c_bus, NULL, "samsung,exynos4212-i2c-isp") { + for_each_compatible_node_scoped(i2c_bus, NULL, "samsung,exynos4212-i2c-isp") { for_each_available_child_of_node_scoped(i2c_bus, child) { ret = fimc_is_parse_sensor_config(is, index, child); - if (ret < 0 || index >= FIMC_IS_SENSORS_NUM) { - of_node_put(i2c_bus); + if (ret < 0 || index >= FIMC_IS_SENSORS_NUM) return ret; - } + index++; } }