From: Michael Paquier Date: Wed, 3 Jun 2026 03:47:22 +0000 (+0900) Subject: Fix copy-paste error in hash_record_extended() X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=273a3c77615e793089b2f41b666b6fcaa970a0c9;p=thirdparty%2Fpostgresql.git Fix copy-paste error in hash_record_extended() The code failed to initialize the second isnull argument passed to FunctionCallInvoke(). This is harmless for existing in-core extended hash support functions, since FunctionCallInvoke() does not use the value (note that all the in-core extended hash functions are strict), examining only the argument values. However, extension-provided extended hash functions could be affected if they inspect PG_ARGISNULL(1). Oversight in 01e658fa74cb. Author: Man Zeng Discussion: https://postgr.es/m/tencent_7818173C01E01836109848C3@qq.com Backpatch-through: 14 --- diff --git a/src/backend/utils/adt/rowtypes.c b/src/backend/utils/adt/rowtypes.c index e4eb7111ee7..d6126d431d9 100644 --- a/src/backend/utils/adt/rowtypes.c +++ b/src/backend/utils/adt/rowtypes.c @@ -2030,7 +2030,7 @@ hash_record_extended(PG_FUNCTION_ARGS) locfcinfo->args[0].value = values[i]; locfcinfo->args[0].isnull = false; locfcinfo->args[1].value = Int64GetDatum(seed); - locfcinfo->args[0].isnull = false; + locfcinfo->args[1].isnull = false; element_hash = DatumGetUInt64(FunctionCallInvoke(locfcinfo)); /* We don't expect hash support functions to return null */