From: Anna Norokh -X (anorokh - SOFTSERVE INC at Cisco) <anorokh@cisco.com>
Date: Fri, 30 Jan 2026 08:02:43 +0000 (+0000)
Subject: Pull request #5127: test: fix comparison for pointers in check tests
X-Git-Tag: 3.11.1.0~30
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=3206bc19c805bed11a307984474b05ff180fe4e6;p=thirdparty%2Fsnort3.git

Pull request #5127: test: fix comparison for pointers in check tests

Merge in SNORT/snort3 from ~ANOROKH/snort3:fix_mac_os to master

Squashed commit of the following:

commit 1d878c766464d72b5ecb4f77581255f1521ba9d5
Author: anorokh <anorokh@cisco.com>
Date:   Tue Jan 27 01:29:23 2026 +0100

    test: fix comparison for pointers in check tests
---

diff --git a/src/network_inspectors/appid/test/appid_api_test.cc b/src/network_inspectors/appid/test/appid_api_test.cc
index 33690c9b3..58025131f 100644
--- a/src/network_inspectors/appid/test/appid_api_test.cc
+++ b/src/network_inspectors/appid/test/appid_api_test.cc
@@ -396,10 +396,10 @@ TEST(appid_api, ssl_app_group_id_lookup_zero_len_data)
         test_zero_tls_data, test_zero_tls_data, true, service, client, payload);
 
     CHECK_TRUE(val);
-    CHECK_EQUAL(mock_session->tsession->get_tls_sni(), nullptr);
-    CHECK_EQUAL(mock_session->tsession->get_tls_first_alt_name(), nullptr);
-    CHECK_EQUAL(mock_session->tsession->get_tls_cname(), nullptr);
-    CHECK_EQUAL(mock_session->tsession->get_tls_org_unit(), nullptr);
+    POINTERS_EQUAL(mock_session->tsession->get_tls_sni(), nullptr);
+    POINTERS_EQUAL(mock_session->tsession->get_tls_first_alt_name(), nullptr);
+    POINTERS_EQUAL(mock_session->tsession->get_tls_cname(), nullptr);
+    POINTERS_EQUAL(mock_session->tsession->get_tls_org_unit(), nullptr);
     mock().checkExpectations();
 }
 
diff --git a/src/protocols/test/ssl_protocol_test.cc b/src/protocols/test/ssl_protocol_test.cc
index 7a319ef70..64f860066 100644
--- a/src/protocols/test/ssl_protocol_test.cc
+++ b/src/protocols/test/ssl_protocol_test.cc
@@ -107,7 +107,7 @@ TEST(ssl_protocol_tests, cert_data_incomplete_len_2)
     test_data.certs_len = 2;
     auto result = parse_server_certificates(&test_data);
     CHECK_EQUAL(true, result);
-    CHECK_EQUAL(nullptr, test_data.certs_data);
+    POINTERS_EQUAL(nullptr, test_data.certs_data);
     CHECK_EQUAL(0, test_data.certs_len);
 }