From: Arаm Sаrgsyаn <aram@isc.org>
Date: Wed, 2 Oct 2024 09:51:40 +0000 (+0000)
Subject: fix: dev: Don't ignore the local port number in dns_dispatch_add() for TCP
X-Git-Tag: v9.21.2~4
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=41f4c620c2e146faee7e92f234f4650dc31076ed;p=thirdparty%2Fbind9.git

fix: dev: Don't ignore the local port number in dns_dispatch_add() for TCP

The dns_dispatch_add() function registers the 'resp' entry in
'disp->mgr->qids' hash table with 'resp->port' being 0, but in
tcp_recv_success(), when looking up an entry in the hash table
after a successfully received data the port is used, so if the
local port was set (i.e. it was not 0) it fails to find the
entry and results in an unexpected error.

Set the 'resp->port' to the given local port value extracted from
'disp->local'.

Closes #4969

Merge branch '4969-dispatch-tcp-source-port-bug-fix' into 'main'

See merge request isc-projects/bind9!9576
---

41f4c620c2e146faee7e92f234f4650dc31076ed