From: Nikolay Kulikov Date: Thu, 30 Apr 2026 17:29:06 +0000 (+0300) Subject: staging: rtl8723bs: rename DisableInterrupt8723BSdio() to snake_case X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=52a6ca2c869304bd898e5147b3e68c858b31282f;p=thirdparty%2Flinux.git staging: rtl8723bs: rename DisableInterrupt8723BSdio() to snake_case Rename function DisableInterrupt8723BSdio() to rtw_sdio_disable_interrupt() and format its description to comply with Linux kernel coding style. Declare this function without 'extern' prototype in the .h file to fix checkpatch.pl warning. Signed-off-by: Nikolay Kulikov Reviewed-by: Luka Gejak Link: https://patch.msgid.link/20260430172954.12828-3-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c index 77a6a5c7ec7e..5d74913be573 100644 --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c @@ -626,16 +626,13 @@ void rtw_sdio_enable_interrupt(struct adapter *adapter) rtw_write8(adapter, REG_C2HEVT_CLEAR, C2H_EVT_HOST_CLOSE); } -/* */ -/* Description: */ -/* Disable SDIO Host IMR configuration to mask unnecessary interrupt service. */ -/* */ -/* Assumption: */ -/* Using SDIO Local register ONLY for configuration. */ -/* */ -/* Created by Roger, 2011.02.11. */ -/* */ -void DisableInterrupt8723BSdio(struct adapter *adapter) +/* + * Disable SDIO Host IMR configuration to mask unnecessary interrupt service. + * + * Assumption: + * Using SDIO Local register ONLY for configuration. + */ +void rtw_sdio_disable_interrupt(struct adapter *adapter) { __le32 himr; diff --git a/drivers/staging/rtl8723bs/include/sdio_ops.h b/drivers/staging/rtl8723bs/include/sdio_ops.h index 7bb4b2047cc1..13f13076bc16 100644 --- a/drivers/staging/rtl8723bs/include/sdio_ops.h +++ b/drivers/staging/rtl8723bs/include/sdio_ops.h @@ -28,7 +28,7 @@ extern u8 CheckIPSStatus(struct adapter *padapter); extern void InitInterrupt8723BSdio(struct adapter *padapter); extern void InitSysInterrupt8723BSdio(struct adapter *padapter); void rtw_sdio_enable_interrupt(struct adapter *padapter); -extern void DisableInterrupt8723BSdio(struct adapter *padapter); +void rtw_sdio_disable_interrupt(struct adapter *padapter); extern u8 HalQueryTxBufferStatus8723BSdio(struct adapter *padapter); extern void HalQueryTxOQTBufferStatus8723BSdio(struct adapter *padapter); #endif /* !__SDIO_OPS_H__ */ diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index 9270daa018b9..f31196f54b3e 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -1141,7 +1141,7 @@ static int rtw_resume_process_normal(struct adapter *padapter) if (ret) goto exit; } - DisableInterrupt8723BSdio(padapter); + rtw_sdio_disable_interrupt(padapter); /* if (sdio_alloc_irq(adapter_to_dvobj(padapter)) != _SUCCESS) */ if ((padapter->intf_alloc_irq) && (padapter->intf_alloc_irq(adapter_to_dvobj(padapter)) != _SUCCESS)) { ret = -1; diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c index d047481816eb..c43a0391a5ca 100644 --- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c +++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c @@ -211,7 +211,7 @@ static void sd_intf_stop(struct adapter *padapter) if (!padapter) return; - DisableInterrupt8723BSdio(padapter); + rtw_sdio_disable_interrupt(padapter); } @@ -280,7 +280,7 @@ static struct adapter *rtw_sdio_if1_init(struct dvobj_priv *dvobj, const struct /* set mac addr */ rtw_macaddr_cfg(&psdio->func->dev, padapter->eeprompriv.mac_addr); - DisableInterrupt8723BSdio(padapter); + rtw_sdio_disable_interrupt(padapter); status = _SUCCESS;