From: Mukund Sivaraman <muks@isc.org>
Date: Sun, 8 Jun 2014 13:36:37 +0000 (+0530)
Subject: [27303] Supply format string as first arg to printf()
X-Git-Tag: v9.11.0a1~1568
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=5456bddd393aafd9fa5ac4cc905d3ac1b9854635;p=thirdparty%2Fbind9.git

[27303] Supply format string as first arg to printf()

No CHANGES entry for this as it isn't proved to cause an issue for
anyone (isc_msgcat_get() has to return a format specifier) and isn't a
user visible change.

Squashed commit of the following:

commit bcb15c9aa17b0b706aefd9efef5f7e0e951064a3
Author: Mukund Sivaraman <muks@isc.org>
Date:   Wed Jun 4 16:55:16 2014 +0530

    [27303] Supply format string as first arg to printf()

    The old code only had a problem if isc_msgcat_get() returned a format
    specifier (%n).
---

diff --git a/lib/isc/unix/ifiter_sysctl.c b/lib/isc/unix/ifiter_sysctl.c
index 102ecc1fee2..5aad3d2ab82 100644
--- a/lib/isc/unix/ifiter_sysctl.c
+++ b/lib/isc/unix/ifiter_sysctl.c
@@ -258,7 +258,8 @@ internal_current(isc_interfaceiter_t *iter) {
 
 		return (ISC_R_SUCCESS);
 	} else {
-		printf(isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
+		printf("%s",
+		       isc_msgcat_get(isc_msgcat, ISC_MSGSET_IFITERSYSCTL,
 				      ISC_MSG_UNEXPECTEDTYPE,
 				      "warning: unexpected interface list "
 				      "message type\n"));