From: Michał Kępień <michal@isc.org>
Date: Thu, 21 May 2026 09:52:56 +0000 (+0200)
Subject: Tweak the _get_cookie() method
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=5fa2bd7e53e1d6ee6ebcc04b0bf5f303d3e85570;p=thirdparty%2Fbind9.git

Tweak the _get_cookie() method

The "len(cookie.server) == 0" condition is superfluous for the
"resend_loop" system test, so remove it.  Add a return type annotation
to the _get_cookie() function.
---

diff --git a/bin/tests/system/resend_loop/ans3/ans.py b/bin/tests/system/resend_loop/ans3/ans.py
index 2b8cf4d0181..9dcdec83b53 100644
--- a/bin/tests/system/resend_loop/ans3/ans.py
+++ b/bin/tests/system/resend_loop/ans3/ans.py
@@ -28,13 +28,11 @@ from isctest.asyncserver import (
 )
 
 
-def _get_cookie(qctx: QueryContext):
+def _get_cookie(qctx: QueryContext) -> dns.edns.CookieOption | None:
     for o in qctx.query.options:
         if o.otype == dns.edns.OptionType.COOKIE:
             cookie = o
-            if len(cookie.server) == 0:
-                cookie.server = b"\x11\x22\x33\x44\x55\x66\x77\x88"
-
+            cookie.server = b"\x11\x22\x33\x44\x55\x66\x77\x88"
             return cookie
 
     return None