From: Gabriel Rondon Date: Tue, 31 Mar 2026 16:44:42 +0000 (+0100) Subject: staging: most: dim2: remove unnecessary NULL check in service_done_flag() X-Git-Tag: v7.2-rc1~66^2~199 X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=6aa2b11ce527c23e6a472204ee74fdf4a7411231;p=thirdparty%2Fkernel%2Flinux.git staging: most: dim2: remove unnecessary NULL check in service_done_flag() Remove the !hdm_ch check. hdm_ch is derived from dev->hch + ch_idx (pointer arithmetic on a struct member), so it can never be NULL. Keep only the !hdm_ch->is_initialized check. Reported-by: Dan Carpenter Closes: https://lore.kernel.org/all/acuoL4DRi0pmsQY1@stanley.mountain Signed-off-by: Gabriel Rondon Link: https://patch.msgid.link/20260331164443.47682-1-grondon@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c index 7953d4626752f..f5bd7d44f1656 100644 --- a/drivers/staging/most/dim2/dim2.c +++ b/drivers/staging/most/dim2/dim2.c @@ -271,7 +271,7 @@ static void service_done_flag(struct dim2_hdm *dev, int ch_idx) unsigned long flags; u8 *data; - if (!hdm_ch || !hdm_ch->is_initialized) + if (!hdm_ch->is_initialized) return; spin_lock_irqsave(&dim_lock, flags);