From: Alberto Leiva Popper <ydahhrk@gmail.com>
Date: Fri, 29 May 2026 14:53:34 +0000 (-0600)
Subject: Review of #includes
X-Git-Tag: 1.6.8~1
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=88d6f537967467ecdbbd387d5e66a9b3647db4fd;p=thirdparty%2FFORT-validator.git

Review of #includes
---

diff --git a/src/as_number.h b/src/as_number.h
index 28aec481..65af9220 100644
--- a/src/as_number.h
+++ b/src/as_number.h
@@ -1,9 +1,6 @@
 #ifndef SRC_AS_NUMBER_H_
 #define SRC_AS_NUMBER_H_
 
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdint.h>
 
 struct asn_range {
diff --git a/src/asn1/asn1c/OBJECT_IDENTIFIER.h b/src/asn1/asn1c/OBJECT_IDENTIFIER.h
index 91b4604d..60dd0d5c 100644
--- a/src/asn1/asn1c/OBJECT_IDENTIFIER.h
+++ b/src/asn1/asn1c/OBJECT_IDENTIFIER.h
@@ -5,8 +5,6 @@
 #ifndef	_OBJECT_IDENTIFIER_H_
 #define	_OBJECT_IDENTIFIER_H_
 
-#include <netdb.h>
-
 #include "asn1/asn1c/OCTET_STRING.h"
 #include "asn1/asn1c/asn_codecs_prim.h"
 
diff --git a/src/asn1/asn1c/ber_tlv_tag.h b/src/asn1/asn1c/ber_tlv_tag.h
index 5ba0fe77..cda0846f 100644
--- a/src/asn1/asn1c/ber_tlv_tag.h
+++ b/src/asn1/asn1c/ber_tlv_tag.h
@@ -5,7 +5,6 @@
 #ifndef	_BER_TLV_TAG_H_
 #define	_BER_TLV_TAG_H_
 
-#include <netinet/in.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
diff --git a/src/config.h b/src/config.h
index ee21f0d5..0aaeec89 100644
--- a/src/config.h
+++ b/src/config.h
@@ -1,10 +1,7 @@
 #ifndef SRC_CONFIG_H_
 #define SRC_CONFIG_H_
 
-#include <arpa/inet.h>
 #include <curl/curl.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdint.h>
 
 #include "config/file_type.h"
diff --git a/src/config/log_conf.c b/src/config/log_conf.c
index 8402cdae..813cad98 100644
--- a/src/config/log_conf.c
+++ b/src/config/log_conf.c
@@ -1,9 +1,6 @@
 #include "config/log_conf.h"
 
-#include <arpa/inet.h>
 #include <getopt.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdint.h>
 #include <string.h>
 #include <syslog.h>
diff --git a/src/data_structure/path_builder.h b/src/data_structure/path_builder.h
index 3ad55176..eb23249e 100644
--- a/src/data_structure/path_builder.h
+++ b/src/data_structure/path_builder.h
@@ -1,9 +1,6 @@
 #ifndef SRC_DATA_STRUCTURE_PATH_BUILDER_H_
 #define SRC_DATA_STRUCTURE_PATH_BUILDER_H_
 
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
diff --git a/src/data_structure/uthash.h b/src/data_structure/uthash.h
index e8e3dbe2..1a27ab7b 100644
--- a/src/data_structure/uthash.h
+++ b/src/data_structure/uthash.h
@@ -26,9 +26,6 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 #define UTHASH_VERSION 2.1.0
 
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stddef.h>
 #include <stdint.h>
 #include <stdio.h>
diff --git a/src/json_util.h b/src/json_util.h
index dcd22dbf..fe0b5dc6 100644
--- a/src/json_util.h
+++ b/src/json_util.h
@@ -1,10 +1,7 @@
 #ifndef SRC_JSON_UTIL_H_
 #define SRC_JSON_UTIL_H_
 
-#include <arpa/inet.h>
 #include <jansson.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
diff --git a/src/rtr/pdu.h b/src/rtr/pdu.h
index 35ded498..5716cceb 100644
--- a/src/rtr/pdu.h
+++ b/src/rtr/pdu.h
@@ -1,9 +1,6 @@
 #ifndef RTR_PDU_H_
 #define RTR_PDU_H_
 
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stddef.h>
 #include <stdint.h>
 
diff --git a/src/rtr/pdu_stream.h b/src/rtr/pdu_stream.h
index e827aa9e..d8677a0a 100644
--- a/src/rtr/pdu_stream.h
+++ b/src/rtr/pdu_stream.h
@@ -1,6 +1,8 @@
 #ifndef SRC_RTR_PDU_STREAM_H_
 #define SRC_RTR_PDU_STREAM_H_
 
+#include <arpa/inet.h>
+#include <netinet/in.h>
 #include <stdbool.h>
 
 #include "rtr/pdu.h"
diff --git a/src/rtr/primitive_writer.h b/src/rtr/primitive_writer.h
index f1b541ad..d92dfe6b 100644
--- a/src/rtr/primitive_writer.h
+++ b/src/rtr/primitive_writer.h
@@ -2,7 +2,6 @@
 #define RTR_PRIMITIVE_WRITER_H_
 
 #include <arpa/inet.h>
-#include <netdb.h>
 #include <netinet/in.h>
 #include <stdint.h>
 
diff --git a/src/rtr/rtr.c b/src/rtr/rtr.c
index 9757b9cb..2e6fdeef 100644
--- a/src/rtr/rtr.c
+++ b/src/rtr/rtr.c
@@ -2,6 +2,7 @@
 
 #include <errno.h>
 #include <fcntl.h>
+#include <netdb.h>
 #include <poll.h>
 #include <string.h>
 
diff --git a/src/types/address.h b/src/types/address.h
index 7dbe6ecf..d83ae821 100644
--- a/src/types/address.h
+++ b/src/types/address.h
@@ -1,7 +1,6 @@
 #ifndef SRC_TYPES_ADDRESS_H_
 #define SRC_TYPES_ADDRESS_H_
 
-#include <netdb.h>
 #include <stdbool.h>
 #include <sys/socket.h>
 
diff --git a/src/types/router_key.h b/src/types/router_key.h
index 20549a03..14870a28 100644
--- a/src/types/router_key.h
+++ b/src/types/router_key.h
@@ -1,9 +1,6 @@
 #ifndef SRC_TYPES_ROUTER_KEY_H_
 #define SRC_TYPES_ROUTER_KEY_H_
 
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdint.h>
 
 /*
diff --git a/src/types/serial.h b/src/types/serial.h
index 117789e7..a9b1683d 100644
--- a/src/types/serial.h
+++ b/src/types/serial.h
@@ -1,9 +1,6 @@
 #ifndef SRC_TYPES_SERIAL_H_
 #define SRC_TYPES_SERIAL_H_
 
-#include <arpa/inet.h>
-#include <netdb.h>
-#include <netinet/in.h>
 #include <stdbool.h>
 #include <stdint.h>
 
diff --git a/src/types/vrp.h b/src/types/vrp.h
index a1673c5a..1015c780 100644
--- a/src/types/vrp.h
+++ b/src/types/vrp.h
@@ -2,7 +2,6 @@
 #define SRC_TYPES_VRP_H_
 
 #include <arpa/inet.h>
-#include <netdb.h>
 #include <netinet/in.h>
 #include <stdbool.h>
 #include <stdint.h>