From: Petr Špaček <pspacek@isc.org>
Date: Tue, 13 Aug 2024 14:26:55 +0000 (+0200)
Subject: Add changelog entry for last-minute regression fix
X-Git-Tag: v9.21.0~1
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=8efe1017428d3ed79f4e0904cf0bb18bd49eadfd;p=thirdparty%2Fbind9.git

Add changelog entry for last-minute regression fix
---

diff --git a/doc/arm/changelog.rst b/doc/arm/changelog.rst
index eec1a0db6ae..9aedad8940d 100644
--- a/doc/arm/changelog.rst
+++ b/doc/arm/changelog.rst
@@ -255,6 +255,15 @@ Bug Fixes
   disabled, but for individual names we need to do the accounting even
   if we are forcing the result to be success. :gl:`#4786` :gl:`!9115`
 
+- Don't skip the counting if fcount_incr() is called with force==true
+  (v2) ``8b70722fcb``
+
+  The fcount_incr() was not increasing counter->count when force was set
+  to true, but fcount_decr() would try to decrease the counter leading
+  to underflow and assertion failure.  Swap the order of the arguments
+  in the condition, so the !force is evaluated after incrementing the
+  .count. :gl:`#4846` :gl:`!9298`
+
 - Remove superfluous memset() in isc_nmsocket_init() ``4c363393ff1``
 
   The tlsstream part of the isc_nmsocket_t gets initialized via