From: Michal Nowak <mnowak@isc.org>
Date: Mon, 22 Jun 2026 19:24:33 +0000 (+0200)
Subject: Remove dead stores reported by scan-build
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=955bd4982e4fb61a40c91ba7eba075bcab97b7ca;p=thirdparty%2Fbind9.git

Remove dead stores reported by scan-build

The syncplugin test driver overwrote two dns_name_fromstring() results
without checking them; wrap the calls in CHECK():

    bin/tests/system/hooks/driver/test-syncplugin.c:156:3: warning: Value stored to 'result' is never read [deadcode.DeadStores]
    bin/tests/system/hooks/driver/test-syncplugin.c:158:3: warning: Value stored to 'result' is never read [deadcode.DeadStores]

Assisted-by: Claude:claude-opus-4-8
---

diff --git a/bin/tests/system/hooks/driver/test-syncplugin.c b/bin/tests/system/hooks/driver/test-syncplugin.c
index ef85ef4b833..07aa95861ec 100644
--- a/bin/tests/system/hooks/driver/test-syncplugin.c
+++ b/bin/tests/system/hooks/driver/test-syncplugin.c
@@ -154,12 +154,12 @@ plugin_register(const char *parameters, const void *cfg, const char *cfgfile,
 			goto cleanup;
 		}
 
-		result = dns_name_fromstring(&example2com, "example2.com.",
-					     NULL, 0, isc_g_mctx);
-		result = dns_name_fromstring(&example3com, "example3.com.",
-					     NULL, 0, isc_g_mctx);
-		result = dns_name_fromstring(&example4com, "example4.com.",
-					     NULL, 0, isc_g_mctx);
+		CHECK(dns_name_fromstring(&example2com, "example2.com.", NULL,
+					  0, isc_g_mctx));
+		CHECK(dns_name_fromstring(&example3com, "example3.com.", NULL,
+					  0, isc_g_mctx));
+		CHECK(dns_name_fromstring(&example4com, "example4.com.", NULL,
+					  0, isc_g_mctx));
 
 		if (!dns_name_equal(ctx->origin, &example2com) &&
 		    !dns_name_equal(ctx->origin, &example3com) &&