From: Evan Hunt <each@isc.org>
Date: Tue, 3 Oct 2017 21:07:08 +0000 (-0700)
Subject: [master] fix out-of-order synchronization that affected the dnssec test
X-Git-Tag: v9.12.0b1~105
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=a5a60037e587fdf47a2acbc92cbb90cfb21d764c;p=thirdparty%2Fbind9.git

[master] fix out-of-order synchronization that affected the dnssec test
---

diff --git a/bin/named/server.c b/bin/named/server.c
index aa3a3e5fd07..1ff620434e4 100644
--- a/bin/named/server.c
+++ b/bin/named/server.c
@@ -6049,11 +6049,11 @@ add_keydata_zone(dns_view_t *view, const char *directory, isc_mem_t *mctx) {
 
 	if (pview != NULL) {
 		if (pview->managed_keys != NULL) {
-			dns_zone_synckeyzone(pview->managed_keys);
 			dns_zone_attach(pview->managed_keys,
 					&view->managed_keys);
 			dns_zone_setview(pview->managed_keys, view);
 			dns_view_detach(&pview);
+			dns_zone_synckeyzone(view->managed_keys);
 			return (ISC_R_SUCCESS);
 		}
 
diff --git a/lib/dns/zone.c b/lib/dns/zone.c
index ea69f1407b0..e3b2fd5b74c 100644
--- a/lib/dns/zone.c
+++ b/lib/dns/zone.c
@@ -4220,8 +4220,7 @@ sync_keyzone(dns_zone_t *zone, dns_db_t *db) {
 		dns_name_t *rrname = NULL;
 		isc_uint32_t ttl;
 
-		dns_rriterator_current(&rrit, &rrname, &ttl,
-				       &rdataset, NULL);
+		dns_rriterator_current(&rrit, &rrname, &ttl, &rdataset, NULL);
 		if (!dns_rdataset_isassociated(rdataset)) {
 			dns_rriterator_destroy(&rrit);
 			goto failure;