From: Michal Nowak <mnowak@isc.org>
Date: Mon, 29 Jun 2026 11:41:20 +0000 (+0000)
Subject: Assert rdataset precondition in query_addrrset()
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=a9e35ee97005d685f9a6f36be328b2e87ee3e939;p=thirdparty%2Fbind9.git

Assert rdataset precondition in query_addrrset()

rdataset is always non-NULL and is dereferenced unconditionally below.
Make the precondition explicit to silence a scan-build false positive:

    lib/ns/query.c:2254:11: warning: Access to field 'type' results in a dereference of a null pointer (loaded from variable 'rdataset') [core.NullDereference]

Assisted-by: Claude:claude-opus-4-8
---

diff --git a/lib/ns/query.c b/lib/ns/query.c
index 306f6e3bceb..0b14141b5c3 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -2172,6 +2172,7 @@ query_addrrset(query_ctx_t *qctx, dns_name_t **namep,
 	CTRACE(ISC_LOG_DEBUG(3), "query_addrrset");
 
 	REQUIRE(name != NULL);
+	REQUIRE(rdataset != NULL);
 
 	if (sigrdatasetp != NULL) {
 		sigrdataset = *sigrdatasetp;