From: Bob Halley <halley@dnspython.org>
Date: Mon, 25 May 2026 19:36:31 +0000 (-0700)
Subject: fix encoding bug with new EDNS options; apply black
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=b6d51b5b7e48c974505a42e3f982af7d0b0f0e99;p=thirdparty%2Fdnspython.git

fix encoding bug with new EDNS options; apply black
---

diff --git a/dns/edns.py b/dns/edns.py
index a60f89cb..31c1e8b0 100644
--- a/dns/edns.py
+++ b/dns/edns.py
@@ -539,7 +539,7 @@ class EDEExtraTextLanguageOption(Option):
             file.write(self.language.encode("utf8"))
             return None
         else:
-            return self.language
+            return self.language.encode()
 
     def to_text(self) -> str:
         return f"EDE-EXTRA-TEXT-LANGUAGE {self.language}"
@@ -569,7 +569,7 @@ class FilteringContactOption(Option):
             file.write(self.contact.encode("utf8"))
             return None
         else:
-            return self.contact
+            return self.contact.encode()
 
     def to_text(self) -> str:
         return f"FILTERING-CONTACT {self.contact}"
@@ -599,7 +599,7 @@ class FilteringOrganizationOption(Option):
             file.write(self.organization.encode("utf8"))
             return None
         else:
-            return self.organization
+            return self.organization.encode()
 
     def to_text(self) -> str:
         return f"FILTERING-ORGANIZATION {self.organization}"
@@ -633,7 +633,7 @@ class FilteringDBOption(Option):
             file.write(self.db.encode("utf8"))
             return None
         else:
-            return self.db
+            return self.db.encode()
 
     def to_text(self) -> str:
         return f"FILTERING-DB {self.db}"
diff --git a/tests/test_dnssec.py b/tests/test_dnssec.py
index b1995034..dd2b44ea 100644
--- a/tests/test_dnssec.py
+++ b/tests/test_dnssec.py
@@ -1251,7 +1251,7 @@ class DNSSECMakeDSTestCase(unittest.TestCase):
                 with self.assertRaises(dns.exception.SyntaxError) as cm:
                     dns.rdata.from_text(dns.rdataclass.IN, dns.rdatatype.CDS, record)
                 # we don't test the message because it varies between pre=3.15 and 3.15
-                #self.assertEqual(msg, str(cm.exception))
+                # self.assertEqual(msg, str(cm.exception))
 
     def testMakeCDS(self):  # type: () -> None
         name = dns.name.from_text("example.com")
diff --git a/tests/test_edns.py b/tests/test_edns.py
index 6bf044ec..36c1a7b2 100644
--- a/tests/test_edns.py
+++ b/tests/test_edns.py
@@ -277,7 +277,9 @@ class OptionTestCase(unittest.TestCase):
         self.assertEqual(str(opt), "EDE-EXTRA-TEXT-LANGUAGE en")
         opt2 = dns.edns.option_from_wire(
             dns.edns.OptionType.EDE_EXTRA_TEXT_LANGUAGE,
-            expected_wire, 0, len(expected_wire)
+            expected_wire,
+            0,
+            len(expected_wire),
         )
         self.assertEqual(opt2.language, language)
 
@@ -291,8 +293,7 @@ class OptionTestCase(unittest.TestCase):
         self.assertEqual(data, expected_wire)
         self.assertEqual(str(opt), "FILTERING-CONTACT mailto:support@example.com")
         opt2 = dns.edns.option_from_wire(
-            dns.edns.OptionType.FILTERING_CONTACT,
-            expected_wire, 0, len(expected_wire)
+            dns.edns.OptionType.FILTERING_CONTACT, expected_wire, 0, len(expected_wire)
         )
         self.assertEqual(opt2.contact, contact)
 
@@ -307,7 +308,9 @@ class OptionTestCase(unittest.TestCase):
         self.assertEqual(str(opt), "FILTERING-ORGANIZATION The Example Organization")
         opt2 = dns.edns.option_from_wire(
             dns.edns.OptionType.FILTERING_ORGANIZATION,
-            expected_wire, 0, len(expected_wire)
+            expected_wire,
+            0,
+            len(expected_wire),
         )
         self.assertEqual(opt2.organization, organization)
 
@@ -321,8 +324,7 @@ class OptionTestCase(unittest.TestCase):
         self.assertEqual(data, expected_wire)
         self.assertEqual(str(opt), "FILTERING-DB Government Anti-Piracy Policies #1")
         opt2 = dns.edns.option_from_wire(
-            dns.edns.OptionType.FILTERING_DB,
-            expected_wire, 0, len(expected_wire)
+            dns.edns.OptionType.FILTERING_DB, expected_wire, 0, len(expected_wire)
         )
         self.assertEqual(opt2.db, db)
 
diff --git a/tests/test_svcb.py b/tests/test_svcb.py
index c1a8a6ab..9b217f7d 100644
--- a/tests/test_svcb.py
+++ b/tests/test_svcb.py
@@ -268,7 +268,6 @@ class SVCBTestCase(unittest.TestCase):
         )
         self.check_invalid_inputs(invalid_inputs)
 
-
     def test_svcb_unknown(self):
         valid_inputs_one_key = (
             '1 . key23="key45"',