From: Mark Andrews <marka@isc.org>
Date: Wed, 5 Jun 2024 03:59:39 +0000 (+1000)
Subject: Add missing period to generated IPv4 6to4 name
X-Git-Tag: alessio/regression/026024a6ae~13^2~2
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=bca63437a15d857cdf79ca1f1bbcb5e5062e5fb8;p=thirdparty%2Fbind9.git

Add missing period to generated IPv4 6to4 name

The period between the most significant nibble of the IPv4 address
and the 2.0.0.2.IP6.ARPA suffix was missing resulting in the wrong
name being checked.
---

diff --git a/lib/dns/ssu.c b/lib/dns/ssu.c
index b54157ecc16..b43c7cfac38 100644
--- a/lib/dns/ssu.c
+++ b/lib/dns/ssu.c
@@ -245,13 +245,12 @@ stf_from_address(dns_name_t *stfself, const isc_netaddr_t *tcpaddr) {
 	switch (tcpaddr->family) {
 	case AF_INET:
 		l = ntohl(tcpaddr->type.in.s_addr);
-		result = snprintf(buf, sizeof(buf),
-				  "%lx.%lx.%lx.%lx.%lx.%lx.%lx.%lx"
-				  "2.0.0.2.IP6.ARPA.",
-				  l & 0xf, (l >> 4) & 0xf, (l >> 8) & 0xf,
-				  (l >> 12) & 0xf, (l >> 16) & 0xf,
-				  (l >> 20) & 0xf, (l >> 24) & 0xf,
-				  (l >> 28) & 0xf);
+		result = snprintf(
+			buf, sizeof(buf),
+			"%lx.%lx.%lx.%lx.%lx.%lx.%lx.%lx.2.0.0.2.IP6.ARPA.",
+			l & 0xf, (l >> 4) & 0xf, (l >> 8) & 0xf,
+			(l >> 12) & 0xf, (l >> 16) & 0xf, (l >> 20) & 0xf,
+			(l >> 24) & 0xf, (l >> 28) & 0xf);
 		RUNTIME_CHECK(result < sizeof(buf));
 		break;
 	case AF_INET6: