From: Mark Andrews <marka@isc.org>
Date: Tue, 16 Apr 2019 05:34:22 +0000 (+1000)
Subject: add assertions to silence clang false positive
X-Git-Tag: v9.15.0~33^2
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=bed9ad79badb28cdccbe7937da111ce35eb7570c;p=thirdparty%2Fbind9.git

add assertions to silence clang false positive
---

diff --git a/lib/ns/query.c b/lib/ns/query.c
index 6e9ed7aad76..6cba28fa7a4 100644
--- a/lib/ns/query.c
+++ b/lib/ns/query.c
@@ -6478,11 +6478,15 @@ query_checkrpz(query_ctx_t *qctx, isc_result_t result) {
  */
 static isc_result_t
 query_rpzcname(query_ctx_t *qctx, dns_name_t *cname) {
-	ns_client_t *client = qctx->client;
+	ns_client_t *client;
 	dns_fixedname_t prefix, suffix;
 	unsigned int labels;
 	isc_result_t result;
 
+	REQUIRE(qctx != NULL && qctx->client != NULL);
+
+	client = qctx->client;
+
 	CTRACE(ISC_LOG_DEBUG(3), "query_rpzcname");
 
 	labels = dns_name_countlabels(cname);