From: Jakub Kicinski Date: Sat, 23 May 2026 01:40:50 +0000 (-0700) Subject: Merge branch 'net-dsa-microchip-remove-unnecessary-ksz_dev_ops-callbacks' X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=c0aa5f13826dcb035bec3d6b252e6b2020fa5f88;p=thirdparty%2Fkernel%2Flinux.git Merge branch 'net-dsa-microchip-remove-unnecessary-ksz_dev_ops-callbacks' Bastien Curutchet says: ==================== net: dsa: microchip: Remove unnecessary ksz_dev_ops callbacks This series continues the rework of the KSZ driver initiated by a previous series (see [1]), following the discussion we had here [2]. The KSZ driver got way too convoluted over time because it uses a common framework to handle more than 20 switches split in 5 families (see below table) +----------+---------+---------+---------+---------+---------+ | Family | KSZ8463 | KSZ87xx | KSZ88xx | KSZ9477 | LAN937X | +----------+---------+---------+---------+---------+---------+ | Switches | KSZ8463 | KSZ8795 | KSZ88X3 | KSZ8563 | LAN9370 | | | | KSZ8794 | KSZ8864 | KSZ9477 | LAN9371 | | | | KSZ8765 | KSZ8895 | KSZ9896 | LAN9372 | | | | | | KSZ9897 | LAN9373 | | | | | | KSZ9893 | LAN9374 | | | | | | KSZ9563 | | | | | | | KSZ8567 | | | | | | | KSZ9567 | | | | | | | LAN9646 | | +----------+---------+---------+---------+---------+---------+ The previous series ([1]) replaced the unique dsa_swicth_ops struct used by all the KSZ families with one dsa_switch_ops struct for each family. These dsa_switch_ops structs still rely on common functions that redirect the calls to ksz_dev_ops operations which are custom to each switch family. Many of hese ksz_dev_ops callbacks have a direct equivalent in the struct dsa_switch_ops. This series directly connects the implementations of these ksz_dev_ops operations to the relevant dsa_switch_ops attribute to get rid of one unnecessary level of indirection. On top of this on-going rework I added PTP and periodic output support for the KSZ8463 (which was my first goal). There are more than 60 patches for all this so this series will be followed by several others and if you want to see the full picture we can check my github ([3]). I haven't finished yet to group all the patches into meaningful series but here is more or less what I plan to do next: - A series will split again some operations to get rid of the if (is_kszXYZ) branches. - Maybe another series will be needed to completely move out of ksz_common.c everything that isn't truly common to all the switches - A series will add PTP support for the KSZ8463 - A final series will add periodic output support for the KSZ8463 FYI, I only have a KSZ8463 so, unfortunately, I can't test other switches. [1]: https://lore.kernel.org/r/20260505-clean-ksz-driver-v1-0-05d70fa42461@bootlin.com [2]: https://lore.kernel.org/r/20260304-ksz8463-ptp-v6-0-3f4c47954c71@bootlin.com) [3]: https://github.com/bastien-curutchet/linux/tree/ksz_rework ==================== Link: https://patch.msgid.link/20260521-clean-ksz-2nd-series-v3-0-75c38971c19a@bootlin.com Signed-off-by: Jakub Kicinski --- c0aa5f13826dcb035bec3d6b252e6b2020fa5f88