From: Ilia Shipitsin <chipitsine@gmail.com>
Date: Sun, 31 May 2026 07:14:39 +0000 (+0200)
Subject: CLEANUP: ncbmbuf: improve handling of memory allocation errors in unit tests
X-Git-Tag: v3.4.0~44
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=c1d6973571a4c6798f746c6a64e9d71b46ab49e5;p=thirdparty%2Fhaproxy.git

CLEANUP: ncbmbuf: improve handling of memory allocation errors in unit tests

Found via cppcheck  --force --enable=all --output-file=haproxy.log :

src/ncbmbuf.c:192:9: warning: If memory allocation fails, then there is a possible null pointer dereference: area [nullPointerOutOfMemory]
src/ncbmbuf.c:373:9: warning: If memory allocation fails, then there is a possible null pointer dereference: data [nullPointerOutOfMemory]
src/ncbmbuf.c:546:9: warning: If memory allocation fails, then there is a possible null pointer dereference: data [nullPointerOutOfMemory]
---

diff --git a/src/ncbmbuf.c b/src/ncbmbuf.c
index 222737ea6..e642e3d21 100644
--- a/src/ncbmbuf.c
+++ b/src/ncbmbuf.c
@@ -370,6 +370,12 @@ void test_ncbmb(void)
 	char *data = calloc(16384, 1);
 	struct ncbmbuf buf;
 
+	if (!area || !data) {
+		free(area);
+		free(data);
+		return;
+	}
+
 	memset(data, 0x11, 16384);
 
 	/* 7 bytes data // 1 byte bitmap (0xfe) */
@@ -543,6 +549,12 @@ void test_ngtcp2_crypto(void)
 	char *data = calloc(16384, 1);
 	struct ncbmbuf buf;
 
+	if (!area || !data) {
+		free(area);
+		free(data);
+		return;
+	}
+
 	memset(data, 0x11, 16384);
 
 	buf = ncbmb_make(area, 16384, 0);