From: Chen Ni Date: Mon, 2 Feb 2026 02:43:12 +0000 (+0800) Subject: media: i2c: mt9p031: Check return value of devm_gpiod_get_optional() in mt9p031_probe() X-Git-Tag: v7.1-rc1~169^2~189 X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=c8e0585dce5df525308f0fba40b618df03aaf7fc;p=thirdparty%2Fkernel%2Flinux.git media: i2c: mt9p031: Check return value of devm_gpiod_get_optional() in mt9p031_probe() The devm_gpiod_get_optional() function may return an error pointer (ERR_PTR) in case of a genuine failure during GPIO acquisition, not just NULL which indicates the legitimate absence of an optional GPIO. Add an IS_ERR() check after the function call to catch such errors and propagate them to the probe function, ensuring the driver fails to load safely rather than proceeding with an invalid pointer. Signed-off-by: Chen Ni Signed-off-by: Sakari Ailus Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i2c/mt9p031.c index 1500ee4db47ec..ea5d43d925ffa 100644 --- a/drivers/media/i2c/mt9p031.c +++ b/drivers/media/i2c/mt9p031.c @@ -1183,6 +1183,10 @@ static int mt9p031_probe(struct i2c_client *client) mt9p031->reset = devm_gpiod_get_optional(&client->dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(mt9p031->reset)) { + ret = PTR_ERR(mt9p031->reset); + goto done; + } ret = mt9p031_clk_setup(mt9p031); if (ret)