From: Maxime Chevallier Date: Tue, 28 Apr 2026 12:58:27 +0000 (+0200) Subject: net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=e2d217fe3ff2a73ace0dbfe41b620c7fb767b000;p=thirdparty%2Fkernel%2Flinux.git net: phy: aquantia: use ADVERTISE_XNP for extended next page advertising When configuring the link parameters in forced mode for the AQR-105, the Extended Next Page bit gets advertised for Multi-Gigabit modes. This is done through bit 12 of MDIO_AN_ADVERTISE in MDIO_MMD_AN. This contains a copy of the MII_ADVERTISE, for which 802.3 defines bit 12 as the Extended Next Page advertising. This bit used to be marked as reserved, but a proper define for it was added in : commit e7a62edd34b1 ("net: phy: qcom: at803x: Use the correct bit to disable extended next page") Let's use it instead of the ADVERTISE_RESV definition, making the code more self-documenting. Signed-off-by: Maxime Chevallier Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20260428125827.238469-1-maxime.chevallier@bootlin.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c index 41f3676c7f1ec..e95d391a6dc23 100644 --- a/drivers/net/phy/aquantia/aquantia_main.c +++ b/drivers/net/phy/aquantia/aquantia_main.c @@ -385,15 +385,15 @@ static int aqr105_setup_forced(struct phy_device *phydev) vend |= MDIO_AN_VEND_PROV_1000BASET_HALF; break; case SPEED_2500: - adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV); + adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP); vend |= MDIO_AN_VEND_PROV_2500BASET_FULL; break; case SPEED_5000: - adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV); + adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP); vend |= MDIO_AN_VEND_PROV_5000BASET_FULL; break; case SPEED_10000: - adv |= (ADVERTISE_NPAGE | ADVERTISE_RESV); + adv |= (ADVERTISE_NPAGE | ADVERTISE_XNP); ctrl10 |= MDIO_AN_10GBT_CTRL_ADV10G; break; default: