From: Thomas Weißschuh <thomas@t-8ch.de>
Date: Tue, 28 Apr 2026 17:38:46 +0000 (+0200)
Subject: libsmartcols: (tests) fix failure reporting in filter test
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=e81fabf5d9eeec1e5fba77bbab01b6cadaf0ff0b;p=thirdparty%2Futil-linux.git

libsmartcols: (tests) fix failure reporting in filter test

The pipeline executes the calls to ts_init_subtest and
ts_finalize_subtest in a subshell. This breaks their functionality
and test failures are not reported properly.

Signed-off-by: Thomas Weißschuh <thomas@t-8ch.de>
---

diff --git a/tests/ts/libsmartcols/filter b/tests/ts/libsmartcols/filter
index fdcca5dad..f597f2be7 100755
--- a/tests/ts/libsmartcols/filter
+++ b/tests/ts/libsmartcols/filter
@@ -47,7 +47,7 @@ FILTERS["and-or"]='(NUM >= 3 && NUM <= 100) || NUM == 0'
 
 FILTERS["as-string"]='NUM == "100"'
 
-printf '%s\n' "${!FILTERS[@]}" | sort | while read name; do
+for name in "${!FILTERS[@]}"; do
 	ts_init_subtest "$prefix-$name"
 	echo "expr: ${FILTERS[$name]}" >> $TS_OUTPUT
 	echo >> $TS_OUTPUT
@@ -94,7 +94,7 @@ FILTERS["le2"]='NUM <= 100.5'
 FILTERS["as-string"]='NUM == "100"'
 FILTERS["as-string2"]='NUM == "100.5"'
 
-printf '%s\n' "${!FILTERS[@]}" | sort | while read name; do
+for name in "${!FILTERS[@]}"; do
 	ts_init_subtest "$prefix-$name"
 	echo "expr: ${FILTERS[$name]}" >> $TS_OUTPUT
 	echo >> $TS_OUTPUT
@@ -133,7 +133,7 @@ FILTERS["ne2"]='BOOL != true'
 FILTERS["as-string"]='BOOL == "0"'
 FILTERS["as-string2"]='BOOL == "1"'
 
-printf '%s\n' "${!FILTERS[@]}" | sort | while read name; do
+for name in "${!FILTERS[@]}"; do
 	ts_init_subtest "$prefix-$name"
 	echo "expr: ${FILTERS[$name]}" >> $TS_OUTPUT
 	echo >> $TS_OUTPUT
@@ -168,7 +168,7 @@ FILTERS["le"]='NAME <= "bbb"'
 FILTERS["reg"]='NAME =~ "aaa.*"'
 FILTERS["nreg"]='NAME !~ "aaa.*"'
 
-printf '%s\n' "${!FILTERS[@]}" | sort | while read name; do
+for name in "${!FILTERS[@]}"; do
 	ts_init_subtest "$prefix-$name"
 	echo "expr: ${FILTERS[$name]}" >> $TS_OUTPUT
 	echo >> $TS_OUTPUT
@@ -197,7 +197,7 @@ FILTERS["bad-column"]='XXX == 100'
 FILTERS["bad-number"]='NUM == 1y0'
 FILTERS["bad-float"]='NUM == 100 . 5'
 
-printf '%s\n' "${!FILTERS[@]}" | sort | while read name; do
+for name in "${!FILTERS[@]}"; do
 	ts_init_subtest "$prefix-$name"
 	echo "expr: ${FILTERS[$name]}" >> $TS_OUTPUT
 	echo >> $TS_OUTPUT