From: Daiki Ueno <ueno@gnu.org>
Date: Thu, 9 Nov 2023 04:33:13 +0000 (+0900)
Subject: cli: fix --ca-auto-retrieve crash when no caIssuer is present in AIA
X-Git-Tag: 3.8.3~4^2~1
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=ebb98fd87edd2c876d3ebadee4249cfd8254f7c0;p=thirdparty%2Fgnutls.git

cli: fix --ca-auto-retrieve crash when no caIssuer is present in AIA

Previously, when caIssuer URI is not present in the certificate's AIA
extension, the callback successfully returned 0, but didn't initialize
the output arguments, resulting in a segmentation fault in the caller.

Signed-off-by: Daiki Ueno <ueno@gnu.org>
---

diff --git a/src/cli.c b/src/cli.c
index ca29a849f2..055d102c6f 100644
--- a/src/cli.c
+++ b/src/cli.c
@@ -2294,6 +2294,12 @@ static int getissuer_callback(const gnutls_x509_trust_list_t tlist,
 		fprintf(stderr,
 			"*** Cannot find caIssuer URI in certificate: %s\n",
 			gnutls_strerror(ret));
+
+		/* Initialize the output arguments as we are not
+		 * treating this as error.
+		 */
+		*issuers = NULL;
+		*issuers_size = 0;
 		return 0;
 	}