From: Mark Andrews <marka@isc.org>
Date: Wed, 27 Jun 2018 01:10:59 +0000 (+1000)
Subject: cfg_parse_boolean's REQUIRE test for ret was incomplete.
X-Git-Tag: v9.13.2~10^2
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=f1ee5e4a166b84bc0ae23dc3eddf251a10d85fac;p=thirdparty%2Fbind9.git

cfg_parse_boolean's REQUIRE test for ret was incomplete.
---

diff --git a/lib/isccfg/parser.c b/lib/isccfg/parser.c
index b9eb9149283..3a10d713f6b 100644
--- a/lib/isccfg/parser.c
+++ b/lib/isccfg/parser.c
@@ -1304,7 +1304,7 @@ cfg_parse_boolean(cfg_parser_t *pctx, const cfg_type_t *type, cfg_obj_t **ret)
 	cfg_obj_t *obj = NULL;
 
 	REQUIRE(pctx != NULL);
-	REQUIRE(ret != NULL && ret != NULL);
+	REQUIRE(ret != NULL && *ret == NULL);
 
 	UNUSED(type);