From: Arvin Schnell <aschnell@suse.de>
Date: Tue, 4 Sep 2012 09:58:30 +0000 (+0200)
Subject: - fixed resource leak
X-Git-Tag: v0.1.3~119
X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=f8a100396e8635591ebccbb444ed475d788adf56;p=thirdparty%2Fsnapper.git

- fixed resource leak
---

diff --git a/snapper/File.cc b/snapper/File.cc
index 9fc1ed67..165639e9 100644
--- a/snapper/File.cc
+++ b/snapper/File.cc
@@ -339,6 +339,7 @@ namespace snapper
 	if (dest_fd < 0)
 	{
 	    y2err("open failed errno:" << errno << " (" << stringerror(errno) << ")");
+	    close(src_fd);
 	    return false;
 	}
 
@@ -346,6 +347,8 @@ namespace snapper
 	if (r1 != 0)
 	{
 	    y2err("fchmod failed errno:" << errno << " (" << stringerror(errno) << ")");
+	    close(dest_fd);
+	    close(src_fd);
 	    return false;
 	}
 
@@ -353,6 +356,8 @@ namespace snapper
 	if (r2 != 0)
 	{
 	    y2err("fchown failed errno:" << errno << " (" << stringerror(errno) << ")");
+	    close(dest_fd);
+	    close(src_fd);
 	    return false;
 	}
 
@@ -363,7 +368,6 @@ namespace snapper
 	}
 
 	close(dest_fd);
-
 	close(src_fd);
 
 	return ret;