From: Nikolay Kulikov Date: Sat, 2 May 2026 21:55:46 +0000 (+0300) Subject: staging: rtl8723bs: remove unused ROMVer from struct hal_version X-Git-Url: http://git.ipfire.org/gitweb/index.cgi?a=commitdiff_plain;h=faf9f114a82001fe3a4b38e4650f3bc203622ae0;p=thirdparty%2Flinux.git staging: rtl8723bs: remove unused ROMVer from struct hal_version 'ROMVer' field of 'sturct hal_version' never used anywhere in the driver, so remove it to eliminate unused code. Remove the related call to rtw_read32(), the result of which is only used for 'ROMVer' and is no longer needed. Signed-off-by: Nikolay Kulikov Link: https://patch.msgid.link/20260502220056.59815-8-nikolayof23@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c index 30cae6e0439b1..4cdef45ae15eb 100644 --- a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c +++ b/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c @@ -840,9 +840,6 @@ static struct hal_version ReadChipVersion8723B(struct adapter *padapter) /* For regulator mode. by tynli. 2011.01.14 */ pHalData->RegulatorMode = ((value32 & SPS_SEL) ? RT_LDO_REGULATOR : RT_SWITCHING_REGULATOR); - value32 = rtw_read32(padapter, REG_GPIO_OUTSTS); - ChipVersion.ROMVer = ((value32 & RF_RL_ID) >> 20); /* ROM code version. */ - /* For multi-function consideration. Added by Roger, 2010.10.06. */ pHalData->MultiFunc = RT_MULTI_FUNC_NONE; value32 = rtw_read32(padapter, REG_MULTI_FUNC_CTRL); diff --git a/drivers/staging/rtl8723bs/include/HalVerDef.h b/drivers/staging/rtl8723bs/include/HalVerDef.h index 249acd83c89f3..90ef37b1ddaed 100644 --- a/drivers/staging/rtl8723bs/include/HalVerDef.h +++ b/drivers/staging/rtl8723bs/include/HalVerDef.h @@ -43,7 +43,6 @@ enum hal_vendor_e { /* tag_HAL_Manufacturer_Version_Definition */ struct hal_version { /* tag_HAL_VERSION */ bool chip_normal; /* true - normal chip, false - test chip */ - u8 ROMVer; }; /* hal_version VersionID; */