]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
3 months agovarious bug fixes in retry.c
Alan T. DeKok [Wed, 18 Feb 2026 20:20:55 +0000 (15:20 -0500)] 
various bug fixes in retry.c

3 months agovarious bug fixes in haproxy.c
Alan T. DeKok [Wed, 18 Feb 2026 20:13:31 +0000 (15:13 -0500)] 
various bug fixes in haproxy.c

3 months agovarious bug fixes in queue.c
Alan T. DeKok [Wed, 18 Feb 2026 19:44:42 +0000 (14:44 -0500)] 
various bug fixes in queue.c

3 months agovarious bug fixes in fd.c
Alan T. DeKok [Wed, 18 Feb 2026 19:41:50 +0000 (14:41 -0500)] 
various bug fixes in fd.c

3 months agokeep blocked flag if we can't flush when already blocked
Alan T. DeKok [Wed, 18 Feb 2026 18:56:44 +0000 (13:56 -0500)] 
keep blocked flag if we can't flush when already blocked

3 months agostop on error, too
Alan T. DeKok [Wed, 18 Feb 2026 18:55:08 +0000 (13:55 -0500)] 
stop on error, too

3 months agovarious buf fixes in mem.c
Alan T. DeKok [Wed, 18 Feb 2026 18:53:22 +0000 (13:53 -0500)] 
various buf fixes in mem.c

3 months agoclean up on failure, and ensure that "next" is always an FD bio
Alan T. DeKok [Wed, 18 Feb 2026 18:33:49 +0000 (13:33 -0500)] 
clean up on failure, and ensure that "next" is always an FD bio

3 months agoreset buffer just in case
Alan T. DeKok [Wed, 18 Feb 2026 18:28:54 +0000 (13:28 -0500)] 
reset buffer just in case

3 months agovarius bug fixes in fd_open.c
Alan T. DeKok [Wed, 18 Feb 2026 18:27:19 +0000 (13:27 -0500)] 
varius bug fixes in fd_open.c

3 months agoreturn dirfd and filename if we have to create it
Alan T. DeKok [Wed, 18 Feb 2026 17:56:16 +0000 (12:56 -0500)] 
return dirfd and filename if we have to create it

3 months agocheck for errors when reading the password from a file
Alan T. DeKok [Wed, 18 Feb 2026 15:58:40 +0000 (10:58 -0500)] 
check for errors when reading the password from a file

3 months agovarious bug fixes in cache.c
Alan T. DeKok [Wed, 18 Feb 2026 15:47:16 +0000 (10:47 -0500)] 
various bug fixes in cache.c

free resources on failure.  Don't set "request=child", as that
just confuses things.

3 months agofix typo to use correct function
Alan T. DeKok [Wed, 18 Feb 2026 15:22:20 +0000 (10:22 -0500)] 
fix typo to use correct function

3 months agofree dh on error
Alan T. DeKok [Wed, 18 Feb 2026 15:16:32 +0000 (10:16 -0500)] 
free dh on error

3 months agorewrite to cache stateless isn't an error for TLS 1.3
Alan T. DeKok [Wed, 18 Feb 2026 14:14:26 +0000 (09:14 -0500)] 
rewrite to cache stateless isn't an error for TLS 1.3

3 months agofix not_before -> not_after typo
Alan T. DeKok [Wed, 18 Feb 2026 14:13:17 +0000 (09:13 -0500)] 
fix not_before -> not_after typo

3 months agoOpenSSL requires calls to engine finish/free
Alan T. DeKok [Wed, 18 Feb 2026 12:48:32 +0000 (07:48 -0500)] 
OpenSSL requires calls to engine finish/free

for all engines, as the ENGINE* pointer is reference counted.

3 months agocall pthread_attr_destroy() for completeness.
Alan T. DeKok [Wed, 18 Feb 2026 12:43:04 +0000 (07:43 -0500)] 
call pthread_attr_destroy() for completeness.

Some platforms may dynamically allocate memory for attr

3 months agohoist extension decode into common routine
Alan T. DeKok [Wed, 18 Feb 2026 02:21:17 +0000 (21:21 -0500)] 
hoist extension decode into common routine

3 months agozero is a valid number of bytes to copy
Alan T. DeKok [Wed, 18 Feb 2026 01:39:19 +0000 (20:39 -0500)] 
zero is a valid number of bytes to copy

3 months agomake function static, and use thread-local variable
Alan T. DeKok [Wed, 18 Feb 2026 01:38:19 +0000 (20:38 -0500)] 
make function static, and use thread-local variable

to match the rest of the code

3 months agovarious bug fixes in ctx.c
Alan T. DeKok [Wed, 18 Feb 2026 01:35:20 +0000 (20:35 -0500)] 
various bug fixes in ctx.c

3 months agovarious bug fixes in session.c
Alan T. DeKok [Wed, 18 Feb 2026 01:31:26 +0000 (20:31 -0500)] 
various bug fixes in session.c

3 months agorequest can be NULL
Alan T. DeKok [Wed, 18 Feb 2026 01:20:56 +0000 (20:20 -0500)] 
request can be NULL

if fr_tls_session_msg_cb() is called via SSL_shutdown() in the
session destructor.

3 months agofix typo to use correct variable
Alan T. DeKok [Wed, 18 Feb 2026 01:18:00 +0000 (20:18 -0500)] 
fix typo to use correct variable

3 months agofix typo, to use the correct log bio
Alan T. DeKok [Wed, 18 Feb 2026 01:10:06 +0000 (20:10 -0500)] 
fix typo, to use the correct log bio

3 months agoinsert / remove engine into tree, and fix list pointer
Alan T. DeKok [Wed, 18 Feb 2026 01:06:42 +0000 (20:06 -0500)] 
insert / remove engine into tree, and fix list pointer

the code finds the engine in the tree, but never inserts it.

3 months agodistinguish "can't encode data" from failure.
Alan T. DeKok [Wed, 18 Feb 2026 00:59:23 +0000 (19:59 -0500)] 
distinguish "can't encode data" from failure.

3 months agohoist clear cache, so we do it even in non-debug mode
Alan T. DeKok [Wed, 18 Feb 2026 00:59:03 +0000 (19:59 -0500)] 
hoist clear cache, so we do it even in non-debug mode

3 months agouse equality check
Alan T. DeKok [Wed, 18 Feb 2026 00:58:45 +0000 (19:58 -0500)] 
use equality check

3 months agocheck return code of function, not TLS connection status
Alan T. DeKok [Wed, 18 Feb 2026 00:38:47 +0000 (19:38 -0500)] 
check return code of function, not TLS connection status

3 months agocheck return code and fail on error
Alan T. DeKok [Tue, 17 Feb 2026 19:50:14 +0000 (14:50 -0500)] 
check return code and fail on error

3 months agouse enum names instead of hard-coded constants
Alan T. DeKok [Tue, 17 Feb 2026 19:49:30 +0000 (14:49 -0500)] 
use enum names instead of hard-coded constants

3 months agodocs-v4: update & reorg developers/bugs section HIVE 3722 / 3727
nolade [Wed, 11 Feb 2026 19:35:54 +0000 (14:35 -0500)] 
docs-v4: update & reorg developers/bugs section HIVE 3722 / 3727

3 months agoset EAP fail if eap_tls_request() fails
Alan T. DeKok [Tue, 17 Feb 2026 16:32:13 +0000 (11:32 -0500)] 
set EAP fail if eap_tls_request() fails

3 months agominor tweaks
Alan T. DeKok [Tue, 17 Feb 2026 16:15:35 +0000 (11:15 -0500)] 
minor tweaks

3 months agothere's no need for this to be a uint16_t
Alan T. DeKok [Tue, 17 Feb 2026 16:14:52 +0000 (11:14 -0500)] 
there's no need for this to be a uint16_t

3 months agozero-length fragments with 'M'ore bit set are invalid
Alan T. DeKok [Tue, 17 Feb 2026 16:12:19 +0000 (11:12 -0500)] 
zero-length fragments with 'M'ore bit set are invalid

3 months agofree buffer on error
Alan T. DeKok [Tue, 17 Feb 2026 16:09:16 +0000 (11:09 -0500)] 
free buffer on error

this buffer should really be on the stack?

3 months agovarious bug fixes for chbind.c
Alan T. DeKok [Tue, 17 Feb 2026 16:07:46 +0000 (11:07 -0500)] 
various bug fixes for chbind.c

3 months agowe don't accept TLS records of larger than 64K.
Alan T. DeKok [Tue, 17 Feb 2026 16:03:47 +0000 (11:03 -0500)] 
we don't accept TLS records of larger than 64K.

These are very unlikely to actually work.

3 months agotweak nonnull settings
Alan T. DeKok [Tue, 17 Feb 2026 14:49:17 +0000 (09:49 -0500)] 
tweak nonnull settings

if dict is NULL, it just defaults to internal

3 months agouse Asciidoc headings in configuration files
Alan T. DeKok [Tue, 17 Feb 2026 14:53:25 +0000 (09:53 -0500)] 
use Asciidoc headings in configuration files

not Markdown ones.  the output is slightly different.

perl -p -i -e 's/^#  # /#  = /;s/^#  ## /#  == /;s/^#  ### /#  === /;s/^#  #### /#  ==== /;' $(git grep -l '^#  #' raddb/)

3 months agodelay increment until after everything succeeds
Alan T. DeKok [Tue, 17 Feb 2026 14:30:07 +0000 (09:30 -0500)] 
delay increment until after everything succeeds

which doesn't make a lot of difference practically, as if the
adding fails, we just stop processing all of the dictionaries.

but it keeps the static analyser happy

3 months agobare END is argc=0not argc=1
Alan T. DeKok [Tue, 17 Feb 2026 12:58:16 +0000 (07:58 -0500)] 
bare END is argc=0not argc=1

3 months agoadd more NONNULL
Alan T. DeKok [Tue, 17 Feb 2026 12:58:04 +0000 (07:58 -0500)] 
add more NONNULL

3 months agocheck return of dict_fixup_init, and remove unused ctx
Alan T. DeKok [Tue, 17 Feb 2026 12:51:16 +0000 (07:51 -0500)] 
check return of dict_fixup_init, and remove unused ctx

3 months agoclean up on error
Alan T. DeKok [Tue, 17 Feb 2026 00:16:42 +0000 (19:16 -0500)] 
clean up on error

3 months agodon't free da after it was added to the dictionaries
Alan T. DeKok [Tue, 17 Feb 2026 00:14:15 +0000 (19:14 -0500)] 
don't free da after it was added to the dictionaries

3 months agocorrect return codes in dict_attr_allow_dup
Alan T. DeKok [Tue, 17 Feb 2026 00:06:18 +0000 (19:06 -0500)] 
correct return codes in dict_attr_allow_dup

3 months agovarious bug fixes in dhcpv6 processor.
Alan T. DeKok [Mon, 16 Feb 2026 23:51:02 +0000 (18:51 -0500)] 
various bug fixes in dhcpv6 processor.

* don't free rctx, the framework will clean it up when the stack
  frame pops. And the rctx ptr is cached in mctx->rctx, so freeing
  it will cause errors
* hoist "allocate sbuff" outside of loop

3 months agotypo - use decline config, not request
Alan T. DeKok [Mon, 16 Feb 2026 23:47:24 +0000 (18:47 -0500)] 
typo - use decline config, not request

3 months agofr_pair_list_copy() returns 0 if there are no elements in the list
Alan T. DeKok [Mon, 16 Feb 2026 23:45:19 +0000 (18:45 -0500)] 
fr_pair_list_copy() returns 0 if there are no elements in the list

3 months agoset datalen from str length. CID #1681389
Alan T. DeKok [Mon, 16 Feb 2026 23:41:54 +0000 (18:41 -0500)] 
set datalen from str length.  CID #1681389

3 months agofail on invalid packet codes, instead of dereferencing NULL ptr
Alan T. DeKok [Mon, 16 Feb 2026 17:20:55 +0000 (12:20 -0500)] 
fail on invalid packet codes, instead of dereferencing NULL ptr

this won't happen as the rest of the code is sane, but it's good
to double-check the values to be sure.

3 months agoadd missing Cookie-Load-Fail
Alan T. DeKok [Mon, 16 Feb 2026 17:13:18 +0000 (12:13 -0500)] 
add missing Cookie-Load-Fail

3 months agoMAX is last valid+1
Alan T. DeKok [Mon, 16 Feb 2026 17:08:05 +0000 (12:08 -0500)] 
MAX is last valid+1

3 months agocheck for DO_NOT_RESPOND, and for rcode in authentication continue
Alan T. DeKok [Mon, 16 Feb 2026 17:03:16 +0000 (12:03 -0500)] 
check for DO_NOT_RESPOND, and for rcode in authentication continue

3 months agoensure Disconnect-Request and Protocol-Error save/restore Proxy-State
Alan T. DeKok [Mon, 16 Feb 2026 16:48:21 +0000 (11:48 -0500)] 
ensure Disconnect-Request and Protocol-Error save/restore Proxy-State

3 months agoadd notes for what to do when modifying rlm_rcode_t
Alan T. DeKok [Mon, 16 Feb 2026 16:36:00 +0000 (11:36 -0500)] 
add notes for what to do when modifying rlm_rcode_t

because TIMEOUT was added, and some things were missed

3 months agocorrect logic and add new functionality.
Alan T. DeKok [Mon, 16 Feb 2026 16:05:18 +0000 (11:05 -0500)] 
correct logic and add new functionality.

* RLM_RCODE_TIMEOUT was missing from authenticate handler
* add pointer to documentation if the shared secret is wrong
* allow 'authenticate' section to set reply.Packet-Type
* various other minor tweaks and logic corrections

3 months agodon't add Event-Timestamp in code
Alan T. DeKok [Mon, 16 Feb 2026 16:03:30 +0000 (11:03 -0500)] 
don't add Event-Timestamp in code

it should be a policy.  And ignore Acct-Delay-Time if its value
is unreasonable

3 months agocheck if state_tree_init fails
Alan T. DeKok [Mon, 16 Feb 2026 15:31:47 +0000 (10:31 -0500)] 
check if state_tree_init fails

3 months agotypo
Alan T. DeKok [Mon, 16 Feb 2026 15:31:20 +0000 (10:31 -0500)] 
typo

3 months agofix typos and add missing things
Alan T. DeKok [Mon, 16 Feb 2026 15:18:55 +0000 (10:18 -0500)] 
fix typos and add missing things

3 months agouse process_rctx_t instead of local struct
Alan T. DeKok [Mon, 16 Feb 2026 13:39:34 +0000 (08:39 -0500)] 
use process_rctx_t instead of local struct

any local struct has to go within the process_rctx_t

3 months agoswap check so that our define doesn't create an error
Alan T. DeKok [Mon, 16 Feb 2026 13:38:52 +0000 (08:38 -0500)] 
swap check so that our define doesn't create an error

3 months agoasciidoctor / pandoc are not required to build .debs
Nick Porter [Mon, 16 Feb 2026 15:46:04 +0000 (15:46 +0000)] 
asciidoctor / pandoc are not required to build .debs

3 months agoTests run under Docker don't have sudo
Nick Porter [Mon, 16 Feb 2026 13:25:50 +0000 (13:25 +0000)] 
Tests run under Docker don't have sudo

3 months agovarious bug fixes in cf_file.c
Alan T. DeKok [Mon, 16 Feb 2026 12:49:47 +0000 (07:49 -0500)] 
various bug fixes in cf_file.c

3 months agomake check clearer and more consistent
Alan T. DeKok [Mon, 16 Feb 2026 12:32:17 +0000 (07:32 -0500)] 
make check clearer and more consistent

3 months agoPacify clang scan
Nick Porter [Mon, 16 Feb 2026 11:05:26 +0000 (11:05 +0000)] 
Pacify clang scan

3 months agoCheck return (CID #1681379, #1681380)
Nick Porter [Mon, 16 Feb 2026 09:03:37 +0000 (09:03 +0000)] 
Check return (CID #1681379, #1681380)

3 months agoCheck map->rhs before dereference (CID #1681378)
Nick Porter [Mon, 16 Feb 2026 08:57:08 +0000 (08:57 +0000)] 
Check map->rhs before dereference (CID #1681378)

3 months ago%time.next() needs > 0 input (CID #1681377)
Nick Porter [Mon, 16 Feb 2026 08:51:12 +0000 (08:51 +0000)] 
%time.next() needs > 0 input (CID #1681377)

3 months agoPacify Coverity (CID #1681274)
Nick Porter [Mon, 16 Feb 2026 08:38:17 +0000 (08:38 +0000)] 
Pacify Coverity (CID #1681274)

Not much can be done if the timer is not set.

3 months agoOnly attempt to close fd if it's open (CID #1681275)
Nick Porter [Mon, 16 Feb 2026 08:31:24 +0000 (08:31 +0000)] 
Only attempt to close fd if it's open (CID #1681275)

3 months agoHandle return value (CID #1681276)
Nick Porter [Mon, 16 Feb 2026 08:23:43 +0000 (08:23 +0000)] 
Handle return value (CID #1681276)

Failure to set the timer is not fatal; even with no timer writes, logs
will be written when the buffer is full.

3 months agoEnsure file->log_header exists (CID #1681277)
Nick Porter [Mon, 16 Feb 2026 08:15:10 +0000 (08:15 +0000)] 
Ensure file->log_header exists (CID #1681277)

3 months agoSpelling
Nick Porter [Thu, 12 Feb 2026 15:40:12 +0000 (15:40 +0000)] 
Spelling

3 months agoFix fr_pair_list_replace_by_da
Nick Porter [Thu, 12 Feb 2026 15:39:37 +0000 (15:39 +0000)] 
Fix fr_pair_list_replace_by_da

3 months agoswap order of assignment
Alan T. DeKok [Sun, 15 Feb 2026 21:59:17 +0000 (16:59 -0500)] 
swap order of assignment

so that we don't over-write a value before we read it

3 months agojust replace the value
Alan T. DeKok [Sun, 15 Feb 2026 21:57:56 +0000 (16:57 -0500)] 
just replace the value

3 months agomake cf_item_foreach() safe with remove, and use it in free_children
Alan T. DeKok [Sun, 15 Feb 2026 21:52:49 +0000 (16:52 -0500)] 
make cf_item_foreach() safe with remove, and use it in free_children

which means that the children are removed from the ident trees, too

3 months agoproduce better errors when parsing octal strings.
Alan T. DeKok [Sun, 15 Feb 2026 21:45:50 +0000 (16:45 -0500)] 
produce better errors when parsing octal strings.

because it's still 1981 somewhere.

3 months agoupdate based on returned argv, which may be >1
Alan T. DeKok [Sun, 15 Feb 2026 21:37:30 +0000 (16:37 -0500)] 
update based on returned argv, which may be >1

3 months agoremove unused functions
Alan T. DeKok [Sun, 15 Feb 2026 21:36:59 +0000 (16:36 -0500)] 
remove unused functions

3 months agoupdate variable with mutex held
Alan T. DeKok [Sun, 15 Feb 2026 21:32:06 +0000 (16:32 -0500)] 
update variable with mutex held

3 months agostop iterating over minmax heap if the heap changes
Alan T. DeKok [Sun, 15 Feb 2026 21:30:03 +0000 (16:30 -0500)] 
stop iterating over minmax heap if the heap changes

3 months agocheck previous state, not current state for connected
Alan T. DeKok [Sun, 15 Feb 2026 21:26:53 +0000 (16:26 -0500)] 
check previous state, not current state for connected

3 months agotypo - use correct variable in error message
Alan T. DeKok [Sun, 15 Feb 2026 21:25:40 +0000 (16:25 -0500)] 
typo - use correct variable in error message

3 months agoEAP-SIM doesn't have Packet-Type, and therefore can't have 'finally'
Alan T. DeKok [Sun, 15 Feb 2026 21:22:18 +0000 (16:22 -0500)] 
EAP-SIM doesn't have Packet-Type, and therefore can't have 'finally'

3 months agotweak names and don't pass cs=NULL to log function
Alan T. DeKok [Sun, 15 Feb 2026 21:18:04 +0000 (16:18 -0500)] 
tweak names and don't pass cs=NULL to log function

3 months agofix memory handling
Alan T. DeKok [Sun, 15 Feb 2026 21:05:59 +0000 (16:05 -0500)] 
fix memory handling

don't free mmc, we didn't allocate it.

also free dynamic modules

3 months agofix typo min -> max
Alan T. DeKok [Sun, 15 Feb 2026 21:00:20 +0000 (16:00 -0500)] 
fix typo min -> max

3 months agotrigger is run with mutex held
Alan T. DeKok [Sun, 15 Feb 2026 20:59:39 +0000 (15:59 -0500)] 
trigger is run with mutex held

3 months agoremove state entry from tree if dedup check fails
Alan T. DeKok [Sun, 15 Feb 2026 20:57:33 +0000 (15:57 -0500)] 
remove state entry from tree if dedup check fails

3 months agofix prioritization functions
Alan T. DeKok [Sun, 15 Feb 2026 20:21:36 +0000 (15:21 -0500)] 
fix prioritization functions

so that higher priority requests are handled earlier

3 months agoremove unnecessary code
Alan T. DeKok [Sun, 15 Feb 2026 20:26:34 +0000 (15:26 -0500)] 
remove unnecessary code