]> git.ipfire.org Git - thirdparty/freeradius-server.git/log
thirdparty/freeradius-server.git
2 months agovarious corner cases in PEAP
Alan T. DeKok [Tue, 17 Mar 2026 05:45:40 +0000 (01:45 -0400)] 
various corner cases in PEAP

when TLS API calls fail, return unlang fail.

2 months agocatch corner cases in TTLS.
Alan T. DeKok [Tue, 17 Mar 2026 04:14:11 +0000 (00:14 -0400)] 
catch corner cases in TTLS.

2 months agocatch various extreme corner cases
Alan T. DeKok [Tue, 17 Mar 2026 03:53:34 +0000 (23:53 -0400)] 
catch various extreme corner cases

2 months agofree memory on error, and reference data which is used multiple times
Alan T. DeKok [Tue, 17 Mar 2026 03:32:38 +0000 (23:32 -0400)] 
free memory on error, and reference data which is used multiple times

2 months agohandle the case of zero-length fields
Alan T. DeKok [Tue, 17 Mar 2026 03:18:41 +0000 (23:18 -0400)] 
handle the case of zero-length fields

memcmp() can't handle NULL pointers.

2 months agojust use CMP() macro
Alan T. DeKok [Tue, 17 Mar 2026 03:14:40 +0000 (23:14 -0400)] 
just use CMP() macro

2 months agoremove assert: fr_value_box_cmp() is now a stable comparison
Alan T. DeKok [Tue, 17 Mar 2026 03:00:50 +0000 (23:00 -0400)] 
remove assert: fr_value_box_cmp() is now a stable comparison

2 months agodon't print anything for "make clean"
Alan T. DeKok [Tue, 17 Mar 2026 02:55:30 +0000 (22:55 -0400)] 
don't print anything for "make clean"

2 months agofixed overflow
Catalina Pineros [Mon, 16 Mar 2026 20:03:02 +0000 (16:03 -0400)] 
fixed overflow

if there is KEY_SLOTS, the valid range is [0, KEY_SLOTS - 1], and key KEY_SLOTS should be outside of redis lot range

2 months agofix typos
Catalina Pineros [Mon, 16 Mar 2026 18:32:33 +0000 (14:32 -0400)] 
fix typos

2 months agofix same typo in comment, in different files
Catalina Pineros [Mon, 16 Mar 2026 16:19:27 +0000 (12:19 -0400)] 
fix same typo in comment, in different files

2 months agofix typo in comment
Catalina Pineros [Mon, 16 Mar 2026 16:14:54 +0000 (12:14 -0400)] 
fix typo in comment

2 months agofix typo in comment
Catalina Pineros [Mon, 16 Mar 2026 16:03:07 +0000 (12:03 -0400)] 
fix typo in comment

2 months agofix typo in comment
Catalina Pineros [Mon, 16 Mar 2026 15:58:19 +0000 (11:58 -0400)] 
fix typo in comment

2 months agofix misplaced parenthesis
Catalina Pineros [Mon, 16 Mar 2026 14:55:13 +0000 (10:55 -0400)] 
fix misplaced parenthesis

tolower(cmd_str[1] != s ) does not actually turn anything into lowercase, since it is evaluating a number and not a char

2 months agofr_value_box_cmp() is used in stable sorts
Alan T. DeKok [Mon, 16 Mar 2026 22:18:39 +0000 (18:18 -0400)] 
fr_value_box_cmp() is used in stable sorts

and therefore can't call fr_digest_cmp().

2 months agouse MEMCMP_FIELDS() in paircmp() too
Alan T. DeKok [Mon, 16 Mar 2026 22:18:07 +0000 (18:18 -0400)] 
use MEMCMP_FIELDS() in paircmp() too

and add note about the secret flag

2 months agodefine MEMCMP_FIELDS() and use it
Alan T. DeKok [Mon, 16 Mar 2026 21:47:10 +0000 (17:47 -0400)] 
define MEMCMP_FIELDS() and use it

which is a little clearer (and less wrappers) than MEMCMP_RETURN

2 months agojust call cache_expire() instead of doing it locally
Alan T. DeKok [Mon, 16 Mar 2026 20:54:40 +0000 (16:54 -0400)] 
just call cache_expire() instead of doing it locally

which handles more corner cases.

also other minor tweaks

2 months agotry to clear out 3 cache entries for every 1 lookup
Alan T. DeKok [Mon, 16 Mar 2026 20:51:56 +0000 (16:51 -0400)] 
try to clear out 3 cache entries for every 1 lookup

which lets us clean up old entries more quickly after a spike of
traffic

2 months agorestore write errno after ftruncate in partial header write path
ethan-thompson [Mon, 16 Mar 2026 16:21:51 +0000 (12:21 -0400)] 
restore write errno after ftruncate in partial header write path

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
2 months agofix int truncation of ssize_t return from fr_concatv
ethan-thompson [Mon, 16 Mar 2026 15:43:22 +0000 (11:43 -0400)] 
fix int truncation of ssize_t return from fr_concatv

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
2 months agoskip NULL request pointers when marking batch entries runnable
ethan-thompson [Mon, 16 Mar 2026 15:36:05 +0000 (11:36 -0400)] 
skip NULL request pointers when marking batch entries runnable

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
2 months agouse fr_hash_string for file table lookup to match filename_hash
ethan-thompson [Mon, 16 Mar 2026 15:27:47 +0000 (11:27 -0400)] 
use fr_hash_string for file table lookup to match filename_hash

Signed-off-by: ethan-thompson <ethan.thompson@networkradius.com>
2 months agoalways return "updated" if we updated something
Alan T. DeKok [Mon, 16 Mar 2026 18:18:40 +0000 (14:18 -0400)] 
always return "updated" if we updated something

2 months agocache xlat can succeed if it returns no data.
Alan T. DeKok [Mon, 16 Mar 2026 18:16:39 +0000 (14:16 -0400)] 
cache xlat can succeed if it returns no data.

i.e. "no data in cache" isn't an xlat failure, it's an xlat
success with no data.

2 months agoset_ttl with TTL=0 is a noop
Alan T. DeKok [Mon, 16 Mar 2026 18:09:36 +0000 (14:09 -0400)] 
set_ttl with TTL=0 is a noop

2 months agofix cache it logic
Alan T. DeKok [Mon, 16 Mar 2026 14:44:30 +0000 (10:44 -0400)] 
fix cache it logic

so that it follows the documentation

2 months agopass correct pointer to handle
Alan T. DeKok [Mon, 16 Mar 2026 14:44:09 +0000 (10:44 -0400)] 
pass correct pointer to handle

2 months agoreturn 0 on count error, not negative.
Alan T. DeKok [Mon, 16 Mar 2026 14:42:33 +0000 (10:42 -0400)] 
return 0 on count error, not negative.

because the return value is unsigned.

2 months agoallow tests without the full re-run of all tests
Alan T. DeKok [Mon, 16 Mar 2026 15:27:51 +0000 (11:27 -0400)] 
allow tests without the full re-run of all tests

2 months agocache_foo depends on rlm_cache, too
Alan T. DeKok [Mon, 16 Mar 2026 15:20:08 +0000 (11:20 -0400)] 
cache_foo depends on rlm_cache, too

2 months agoCorrect section name
Nick Porter [Mon, 16 Mar 2026 08:32:20 +0000 (08:32 +0000)] 
Correct section name

2 months agominor cleanups in thread code
Alan T. DeKok [Sun, 15 Mar 2026 22:57:08 +0000 (18:57 -0400)] 
minor cleanups in thread code

2 months agomove fd management to narrower scope
Alan T. DeKok [Sun, 15 Mar 2026 22:47:58 +0000 (18:47 -0400)] 
move fd management to narrower scope

and use fileno(fp), so that we have fewer concerns with managing
the fd

2 months agomove common code to fr_thread_start / fr_thread_exit
Alan T. DeKok [Sun, 15 Mar 2026 19:02:28 +0000 (15:02 -0400)] 
move common code to fr_thread_start / fr_thread_exit

2 months agorename fr_thread functions for clarity
Alan T. DeKok [Sun, 15 Mar 2026 18:32:08 +0000 (14:32 -0400)] 
rename fr_thread functions for clarity

2 months agomove thread information to a common data structure
Alan T. DeKok [Sun, 15 Mar 2026 17:54:58 +0000 (13:54 -0400)] 
move thread information to a common data structure

2 months agomove thread create && wait to common functions
Alan T. DeKok [Sun, 15 Mar 2026 15:30:18 +0000 (11:30 -0400)] 
move thread create && wait to common functions

2 months agomove thread setup to common function
Alan T. DeKok [Sun, 15 Mar 2026 15:16:50 +0000 (11:16 -0400)] 
move thread setup to common function

2 months agomove thread instantiation to common function
Alan T. DeKok [Sun, 15 Mar 2026 15:13:03 +0000 (11:13 -0400)] 
move thread instantiation to common function

2 months agosimplify the names
Alan T. DeKok [Thu, 12 Mar 2026 17:28:55 +0000 (13:28 -0400)] 
simplify the names

less shouting is good.

2 months agoInitial baseline multi-server tests for load-generator -> 5 homeserver and load-gener...
Marc-Andre Casavant [Mon, 23 Feb 2026 19:00:48 +0000 (14:00 -0500)] 
Initial baseline multi-server tests for load-generator -> 5 homeserver and load-generator -> 1 proxy -> 2 homeserver scenarios.

2 months agotweaks, and use fr_dlist_foreach() in more places
Alan T. DeKok [Sun, 15 Mar 2026 13:15:00 +0000 (09:15 -0400)] 
tweaks, and use fr_dlist_foreach() in more places

2 months agowrap multi-line macro in do/while
Alan T. DeKok [Sun, 15 Mar 2026 13:01:54 +0000 (09:01 -0400)] 
wrap multi-line macro in do/while

2 months agofree dbuff on encode failure
Alan T. DeKok [Sun, 15 Mar 2026 12:59:12 +0000 (08:59 -0400)] 
free dbuff on encode failure

2 months agominimize includes
Alan T. DeKok [Sun, 15 Mar 2026 12:58:28 +0000 (08:58 -0400)] 
minimize includes

2 months agoPacify Coverity (CID #1686327)
Nick Porter [Sun, 15 Mar 2026 12:31:10 +0000 (12:31 +0000)] 
Pacify Coverity (CID #1686327)

2 months agoCheck return (CID #1686328)
Nick Porter [Sun, 15 Mar 2026 12:28:42 +0000 (12:28 +0000)] 
Check return (CID #1686328)

2 months agoCheck return (CID #1686329)
Nick Porter [Sun, 15 Mar 2026 12:28:16 +0000 (12:28 +0000)] 
Check return (CID #1686329)

2 months agoda can't be NULL here
Alan T. DeKok [Sun, 15 Mar 2026 02:42:17 +0000 (22:42 -0400)] 
da can't be NULL here

2 months agoreturn failure on error
Alan T. DeKok [Sun, 15 Mar 2026 02:40:56 +0000 (22:40 -0400)] 
return failure on error

2 months agocheck the return code of adding the compile list
Alan T. DeKok [Sun, 15 Mar 2026 02:40:16 +0000 (22:40 -0400)] 
check the return code of adding the compile list

2 months agotypo
Alan T. DeKok [Sun, 15 Mar 2026 02:39:45 +0000 (22:39 -0400)] 
typo

2 months agounify code which warns about unused processing sections
Alan T. DeKok [Sun, 15 Mar 2026 02:38:30 +0000 (22:38 -0400)] 
unify code which warns about unused processing sections

2 months agospelling mistakes
Alan T. DeKok [Sun, 15 Mar 2026 02:27:44 +0000 (22:27 -0400)] 
spelling mistakes

2 months agofix error message typo
Catalina Pineros [Fri, 13 Mar 2026 20:23:47 +0000 (16:23 -0400)] 
fix error message typo

2 months agocheck return value
Catalina Pineros [Fri, 13 Mar 2026 20:13:55 +0000 (16:13 -0400)] 
check return value

if pthread_mutex_init does not succeed,
then trigger_mutex is not intialized,
so return -1

2 months agotypo in comment
Catalina Pineros [Fri, 13 Mar 2026 18:53:15 +0000 (14:53 -0400)] 
typo in comment

2 months agofix typo in comment
Catalina Pineros [Fri, 13 Mar 2026 18:46:31 +0000 (14:46 -0400)] 
fix typo in comment

2 months agofix insert/remove from free_request with preprocessor macro
Catalina Pineros [Fri, 13 Mar 2026 17:43:28 +0000 (13:43 -0400)] 
fix insert/remove from free_request with preprocessor macro

instead of using dlist functions and manually tracking head/tail,
use wrapper functions named for the list being updated, with
clearer and more descriptive names.

2 months agofix comment and debug message typos
Catalina Pineros [Fri, 13 Mar 2026 16:24:04 +0000 (12:24 -0400)] 
fix comment and debug message typos

2 months agofail connection with proper variable values, send error message
Catalina Pineros [Fri, 13 Mar 2026 16:01:49 +0000 (12:01 -0400)] 
fail connection with proper variable values, send error message

set state.last_failed to now,
decrement state.pending to avoid misleading "already at max" error message,
give information in error message when mem alloc fails for a new connection.

2 months agofix memory leak
Catalina Pineros [Thu, 12 Mar 2026 17:19:00 +0000 (13:19 -0400)] 
fix memory leak

close(fd) before returning

2 months agoparser functions return ssize_t
Alan T. DeKok [Fri, 13 Mar 2026 14:18:53 +0000 (10:18 -0400)] 
parser functions return ssize_t

2 months agono need to do head && then remove. Just do pop_head()
Alan T. DeKok [Fri, 13 Mar 2026 12:00:57 +0000 (08:00 -0400)] 
no need to do head && then remove.  Just do pop_head()

2 months agoinsert new trunc requests at head
Catalina Pineros [Thu, 12 Mar 2026 19:44:09 +0000 (15:44 -0400)] 
insert new trunc requests at head
because we free from the tail

2 months agofix typo in comments
Catalina Pineros [Thu, 12 Mar 2026 19:11:02 +0000 (15:11 -0400)] 
fix typo in comments

2 months agofix typo in comments
Catalina Pineros [Thu, 12 Mar 2026 19:01:08 +0000 (15:01 -0400)] 
fix typo in comments

to to, in in, is is

2 months agofix typo in comments
Catalina Pineros [Thu, 12 Mar 2026 18:44:20 +0000 (14:44 -0400)] 
fix typo in comments

the the

2 months agofix typo in comments
Catalina Pineros [Thu, 12 Mar 2026 18:33:04 +0000 (14:33 -0400)] 
fix typo in comments

is is

2 months agofix comment
Catalina Pineros [Thu, 12 Mar 2026 18:07:40 +0000 (14:07 -0400)] 
fix comment

2 months agofix whitespace stripping that never executes
Catalina Pineros [Thu, 12 Mar 2026 17:42:48 +0000 (13:42 -0400)] 
fix whitespace stripping that never executes

buff[2][slen] is set to '/0', which is not a whitespace character, so we need to check buff[2][slen - 1] to actually remove trailing whitespace

2 months agofix error message typo
Catalina Pineros [Thu, 12 Mar 2026 17:30:10 +0000 (13:30 -0400)] 
fix error message typo

2 months agocorrect error path when failing to open file
Alan T. DeKok [Fri, 13 Mar 2026 11:51:13 +0000 (07:51 -0400)] 
correct error path when failing to open file

2 months agoremove extra semicolon
Alan T. DeKok [Fri, 13 Mar 2026 11:50:46 +0000 (07:50 -0400)] 
remove extra semicolon

2 months agoinitialize var
Catalina Pineros [Wed, 11 Mar 2026 14:26:49 +0000 (10:26 -0400)] 
initialize var

2 months agowe can enter closed from shutdown && timeout, too
Alan T. DeKok [Fri, 13 Mar 2026 11:43:16 +0000 (07:43 -0400)] 
we can enter closed from shutdown && timeout, too

_connection_free() and connection_signal_shutdown() both enter
the closed state from the timout state.

2 months agoClean up on failure
Nick Porter [Fri, 13 Mar 2026 09:43:25 +0000 (09:43 +0000)] 
Clean up on failure

2 months agoClarify comment
Nick Porter [Thu, 26 Feb 2026 17:40:19 +0000 (17:40 +0000)] 
Clarify comment

Control planes can be multi-producer, single consumer - so mulitple
threads can send / push a message.

2 months agoAdd coordinator startup / shutdown into scheduler
Nick Porter [Wed, 18 Feb 2026 10:01:10 +0000 (10:01 +0000)] 
Add coordinator startup / shutdown into scheduler

2 months agoAdd coord_attach callback to modules
Nick Porter [Wed, 18 Feb 2026 09:57:26 +0000 (09:57 +0000)] 
Add coord_attach callback to modules

2 months agoAdd support for pair list worker <-> coordinator data
Nick Porter [Wed, 18 Feb 2026 09:31:18 +0000 (09:31 +0000)] 
Add support for pair list worker <-> coordinator data

On the coordinator side the pair list is then converted to a request and run through an interpreter.

2 months agoAdd API for coordniator callback instances
Nick Porter [Tue, 3 Mar 2026 11:39:01 +0000 (11:39 +0000)] 
Add API for coordniator callback instances

Allows callbacks to register an instance create function to create instance data and a set of callbacks to run as part of the event loop.

2 months agoAdd coordinator frame work for sending data messages worker <-> coordinator
Nick Porter [Wed, 18 Feb 2026 09:02:28 +0000 (09:02 +0000)] 
Add coordinator frame work for sending data messages worker <-> coordinator

2 months agoAdd fr_control_wait() to wait for a control message
Nick Porter [Tue, 18 Nov 2025 10:37:11 +0000 (10:37 +0000)] 
Add fr_control_wait() to wait for a control message

2 months agoUse a semaphore to ensure master thread has started before workers
Nick Porter [Thu, 19 Feb 2026 19:40:57 +0000 (19:40 +0000)] 
Use a semaphore to ensure master thread has started before workers

2 months agoUse mmapped memory for POSIX semaphores
Nick Porter [Tue, 18 Nov 2025 08:57:09 +0000 (08:57 +0000)] 
Use mmapped memory for POSIX semaphores

In preparation for using separate processes in place of threads

2 months agoDynamically allocate the number of control plane callbacks
Nick Porter [Fri, 24 Oct 2025 14:07:51 +0000 (15:07 +0100)] 
Dynamically allocate the number of control plane callbacks

To allow the control plane to be used for an arbitrary number of message
IDs

2 months agoMove control message IDs into headers relating to their use
Nick Porter [Fri, 24 Oct 2025 13:10:05 +0000 (14:10 +0100)] 
Move control message IDs into headers relating to their use

2 months agoprint out packet type and ID too
Alan T. DeKok [Thu, 12 Mar 2026 22:28:28 +0000 (18:28 -0400)] 
print out packet type and ID too

2 months agoclean up printing for regexes
Alan T. DeKok [Thu, 12 Mar 2026 18:57:26 +0000 (14:57 -0400)] 
clean up printing for regexes

2 months agoprint out strerror, too
Alan T. DeKok [Thu, 12 Mar 2026 18:15:10 +0000 (14:15 -0400)] 
print out strerror, too

2 months agoflush the output, just in case
Alan T. DeKok [Thu, 12 Mar 2026 17:55:01 +0000 (13:55 -0400)] 
flush the output, just in case

2 months agorun scripts/build/min-includes.pl
Alan T. DeKok [Thu, 12 Mar 2026 11:47:38 +0000 (07:47 -0400)] 
run scripts/build/min-includes.pl

to minimize the number of duplicate includes

2 months agoremove duplicate headers
Alan T. DeKok [Thu, 12 Mar 2026 11:43:08 +0000 (07:43 -0400)] 
remove duplicate headers

perl -ni -e 'print unless (/<(stdbool|stdint|stddef|string).h>/)' $(git grep -l stdbool.h src | grep '\.[ch]' | egrep -v 'build|autoconf' )

2 months agoInclude stdbool.h in default headers
Nick Porter [Thu, 12 Mar 2026 10:14:19 +0000 (10:14 +0000)] 
Include stdbool.h in default headers

2 months agoReturn on negative value (CID #1684172)
Nick Porter [Thu, 12 Mar 2026 09:40:51 +0000 (09:40 +0000)] 
Return on negative value (CID #1684172)

2 months agoonly call marker() functions once.
Alan T. DeKok [Wed, 11 Mar 2026 22:25:17 +0000 (18:25 -0400)] 
only call marker() functions once.

one the second pass, call set()

2 months agochanged error message
Catalina Pineros [Wed, 11 Mar 2026 20:09:17 +0000 (16:09 -0400)] 
changed error message
replaced hardcoded value with the more useful library->autoinit->name